From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id CFEB0385DC00 for ; Wed, 3 Jun 2020 09:56:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CFEB0385DC00 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-168-oRQvQ4TnOA-CZkZJFmEHoQ-1; Wed, 03 Jun 2020 05:56:39 -0400 X-MC-Unique: oRQvQ4TnOA-CZkZJFmEHoQ-1 Received: by mail-wm1-f69.google.com with SMTP id j128so680840wmj.6 for ; Wed, 03 Jun 2020 02:56:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S0yLESpo6eT5IfsdZsxE4url6ZdWEAYguJ4guIrXW6c=; b=Pmoa2bTiaAxHFei7erTdPGATsDQPZdzrT1BsqyVMkaCAkCfyGOsx8HK8YPxb2RObEc nAER2ZXEKqm64IZVU6Ms5/8u/7/LfTFVNRkVAwHsq7FbZdoyGZThrT4zVeZc0NhxdmFV TbTDlL22D+kRJbUoKQmrn2XTIjha/dMMRzv1wxIOba3N2Q78A0q23SU5hvAaW7XtdgOM BmVv9uB7xTDOhfApI9jyKY9YISSHN02kqhyEumGQLhOC18P4sYSSFHT5G7wcpxqjZHwz 42PdFspO7/XUbbjnQAW/ssfMPNkFPXs3uXh5bln8AkHr8adFfTyn+fvQrQtVpKUrYygL BMeQ== X-Gm-Message-State: AOAM533azD/ngQdk+9NDMTxFp0VtirBZooGy4ibPnoyu00GR05mfcfB7 sL8WLyr7VpIjrqx4kXVN2oBNTzkqJ25DgcDWZqwq5G6auBKOqihuFVvIQAAuSQs/fLHoG6XDRL8 fDFVRWxpKLtvTwGAreBT7mA== X-Received: by 2002:adf:f389:: with SMTP id m9mr28403315wro.195.1591178197397; Wed, 03 Jun 2020 02:56:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpXFhNZlafAsTcp/n5AmSKvGhx2YU0dhvFbzCkttHhTABW30yU1faGDmBJxJbyCxB9qm2n0Q== X-Received: by 2002:adf:f389:: with SMTP id m9mr28403298wro.195.1591178197201; Wed, 03 Jun 2020 02:56:37 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id s7sm2612720wrr.60.2020.06.03.02.56.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jun 2020 02:56:36 -0700 (PDT) Subject: Re: [PATCH v2] Add gdb::nullopt, from C++17's std::nullopt To: Christian Biesinger , gdb-patches , Simon Marchi References: <20200519192738.110192-1-cbiesinger@chromium.org> From: Pedro Alves Message-ID: <55056af6-ad5e-5973-bff8-c6f96b4a28b3@redhat.com> Date: Wed, 3 Jun 2020 10:56:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2020 09:56:42 -0000 On 6/2/20 9:27 PM, Christian Biesinger via Gdb-patches wrote: > Ping? Simon/Pedro, any thoughts? As I had said on IRC a few days ago: I remember not including std::nullopt in the original gdb::optional patch for some reason. but I don't remember what reason it was. maybe it was an C++17 inline variable or something. if it works, and the tests pass, I'm happy. ship it. BTW, was this implementation borrowed from libstdc++; or put another way, did you take a look at the implementation from libstdc++, see if there's anything there taking care of some non-obvious issue, that we should mimic? Thanks, Pedro Alves