Re: New ARI warning Fri Feb 27 01:54:21 UTC 2015

Joel Brobecker
2015-02-27T08:24:47Z

Hello John,

I think you patch caused the following warnings. Could you take
a look and fix?

Also, while looking at the patch to confirm the source of the warnings,
I noticed curly braces on the same line as if conditions. Our coding
standard is to have them on the next line. Thus...

if (condition) {
[...]
}

... should be ...

if (condition)
{
[...]
}

Thank you!

On Fri, Feb 27, 2015 at 01:54:22AM +0000, GDB Administrator wrote:
> 16a17
> > gdb/amd64fbsd-tdep.c:54: code: OP eol: Do not use &&, or || at the end of a line
> gdb/amd64fbsd-tdep.c:54: if (memcmp (buf, amd64fbsd_sigtramp_code, sizeof amd64fbsd_sigtramp_code) !=
> 242a244,250
> > gdb/i386fbsd-tdep.c:108: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:108:gdb_static_assert (sizeof i386fbsd_sigtramp_start ==
> > gdb/i386fbsd-tdep.c:110: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:110:gdb_static_assert (sizeof i386fbsd_sigtramp_start ==
> > gdb/i386fbsd-tdep.c:112: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:112:gdb_static_assert (sizeof i386fbsd_sigtramp_middle ==
> > gdb/i386fbsd-tdep.c:114: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:114:gdb_static_assert (sizeof i386fbsd_sigtramp_middle ==
> > gdb/i386fbsd-tdep.c:116: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:116:gdb_static_assert (sizeof i386fbsd_sigtramp_end ==
> > gdb/i386fbsd-tdep.c:118: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:118:gdb_static_assert (sizeof i386fbsd_sigtramp_end ==
> > gdb/i386fbsd-tdep.c:138: code: OP eol: Do not use &&, or || at the end of a line
> gdb/i386fbsd-tdep.c:138: if (memcmp (buf, i386fbsd_sigtramp_start, sizeof i386fbsd_sigtramp_start) ==

--
Joel