From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12549 invoked by alias); 11 Mar 2015 14:58:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12466 invoked by uid 89); 11 Mar 2015 14:58:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: homiemail-a47.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a47.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Mar 2015 14:58:22 +0000 Received: from homiemail-a47.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a47.g.dreamhost.com (Postfix) with ESMTP id 1A9B428405C; Wed, 11 Mar 2015 07:58:21 -0700 (PDT) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a47.g.dreamhost.com (Postfix) with ESMTPSA id E48BB284058; Wed, 11 Mar 2015 07:58:20 -0700 (PDT) Message-ID: <5500580C.6090400@eagerm.com> Date: Wed, 11 Mar 2015 14:58:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Gary Benson CC: "gdb-patches@sourceware.org" , binutils Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb References: <54FF77D6.7010400@eagerm.com> <20150311100702.GA3698@blade.nx> In-Reply-To: <20150311100702.GA3698@blade.nx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00298.txt.bz2 On 03/11/15 03:07, Gary Benson wrote: > Michael Eager wrote: >> Add support to automatically unzip compressed executable and core >> files. Files will be uncompressed into temporary directory (/tmp or >> $TMPDIR) and are deleted when GDB exits. This should be transparent >> to users, except for disk space requirements. The name of the >> uncompressed file is mentioned, but all references to the file in >> GDB messages is to the file which the user specified. > ... >> diff --git a/gdb/common/filestuff.c b/gdb/common/filestuff.c >> index 14d6324..b2c31fd 100644 >> --- a/gdb/common/filestuff.c >> +++ b/gdb/common/filestuff.c > ... >> +#ifndef GDBSERVER > > Please do not add GDBSERVER conditionals to gdb/common, I spent half > a year removing them all. > > It looks like this code is only used by GDB, not gdbserver, so the > fix is simple, just put the code somewhere GDB-specific. Sure. Any suggestions? gdb_bfd.c seems like the wrong place. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077