From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66543 invoked by alias); 11 Mar 2015 13:52:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66531 invoked by uid 89); 11 Mar 2015 13:52:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 11 Mar 2015 13:52:53 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2BDqp57008318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Mar 2015 09:52:51 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2BDqncv006663; Wed, 11 Mar 2015 09:52:50 -0400 Message-ID: <550048B0.8020403@redhat.com> Date: Wed, 11 Mar 2015 13:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Eli Zaretskii Subject: Re: [PATCH 2/3 v5] Implement remote_bfd_iovec_stat References: <20150311131601.GA5952@blade.nx> <1426081190-9381-3-git-send-email-gbenson@redhat.com> In-Reply-To: <1426081190-9381-3-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00290.txt.bz2 On 03/11/2015 01:39 PM, Gary Benson wrote: > This patch implements the function remote_bfd_iovec_stat using a > vFile:fstat hostio call to the remote target. If vFile:fstat is > not supported GDB creates a dummy result by zeroing the supplied > stat structure and then setting it's st_size field to INT_MAX. > This mimic's GDB's previous behaviour, with the exception that > GDB did not previously zero the structure so all other fields > would have been returned unchanged, which is to say very likely > populated with random values from the stack. Note this reads as if the packet already existed. It should be updated to say something like: Subject: Add "vFile:fstat:", implement remote_bfd_iovec_stat This patch adds a new packet "vFile:fstat:" to gdb. This can be used by to retrieve information about files that have been previously open with vFile:open. This patch then implements the function remote_bfd_iovec_stat using a vFile:fstat hostio call to the remote target. If vFile:fstat is not supported GDB creates a dummy result by zeroing the supplied stat structure and then setting it's st_size field to INT_MAX. This mimic's GDB's previous behaviour, with the exception that GDB did not previously zero the structure so all other fields would have been returned unchanged, which is to say very likely populated with random values from the stack. > +@item vFile:fstat: @var{fd} > +Get information about the open file corresponding to @var{fd}. > +On success the information is returned as a binary attachment > +and the return value is the size of this attachment in bytes. > +If an error occurs the return value is -1. The format of the > +returned binary attachment is as described in @ref{struct stat}. > + > +This packet is not probed by default; the remote stub must request > +it, by supplying an appropriate @samp{qSupported} response > +(@pxref{qSupported}). Thanks for adding this. The patch looks great to me now. Thanks, Pedro Alves