Re: [RFA 1/3] Add new_inferior, inferior_deleted, and new_thread events

Simon Marchi
2017-09-11T11:54:53Z

On 2017-09-10 23:52, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> "This emitted". I also noticed that for other events you used
> "This
> Simon> is notified". Perhaps it would be better to stick with "This is
> Simon> emitted" everywhere to be consistent.
>
> How's this then?
>
> Tom
>
> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 32d7939..39def2a 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -2989,6 +2989,39 @@ invalid state; that is, the @code{is_valid}
> method will return
> This event carries no payload. It is emitted each time @value{GDBN}
> presents a prompt to the user.
>
> +@item events.new_inferior
> +This is emitted when a new inferior is created. Note that the
> +inferior is not necessarily running; in fact, it may not even have an
> +associated executable.
> +
> +The event is of type @code{gdb.NewInferiorEvent}. This has a single
> +attribute:
> +
> +@defvar NewInferiorEvent.inferior
> +The new inferior, a @code{gdb.Inferior} object.
> +@end defvar
> +
> +@item events.inferior_deleted
> +This is emitted when an inferior has been deleted. Note that this is
> +not the same as process exit; it is notified when the inferior itself
> +is removed, say via @code{remove-inferiors}.
> +
> +The event is of type @code{gdb.InferiorDeletedEvent}. This has a
> single
> +attribute:
> +
> +@defvar NewInferiorEvent.inferior
> +The inferior that is being removed, a @code{gdb.Inferior} object.
> +@end defvar
> +
> +@item events.new_thread
> +This is emitted when @value{GDBN} notices a new thread. The event is
> of
> +type @code{gdb.NewThreadEvent}, which extends @code{gdb.ThreadEvent}.
> +This has a single attribute:
> +
> +@defvar NewThreadEvent.inferior_thread
> +The new thread.
> +@end defvar
> +
> @end table
>
> @node Threads In Python

LGTM, but please give Eli time to comment.

SImon