From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wDDxInnbTWF/OQAAWB0awg (envelope-from ) for ; Fri, 24 Sep 2021 10:06:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 8C8F11EE25; Fri, 24 Sep 2021 10:06:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=MAILING_LIST_MULTI, NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A35861EDDB for ; Fri, 24 Sep 2021 10:06:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5EBDE3857C71 for ; Fri, 24 Sep 2021 14:06:48 +0000 (GMT) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id D41A53858402 for ; Fri, 24 Sep 2021 14:06:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D41A53858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f53.google.com with SMTP id t28so14488444wra.7 for ; Fri, 24 Sep 2021 07:06:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FBfBs7QGVi/gB75eq3j2gmxIullyL/YQaCgXjZULq7E=; b=TQkFl4OXvGzRW1LknXe54MGD55kIJgxeHH+AJQLVRIh3yLdEkqo0dI5ls0+jgo5KNG EdvXzFfMKf4IyNEElkmxXQCJUiudIjnPAfAAd01oNIbnRtoCuI8Pf/SzuhS86R/Cjeuu jB54y9nqmHpAs1rX++1Sdyvgf/ffebr9VoeMZzdlPFzbGRNjE7m1k2inlvODyNhkxtf9 PtlJ5fT4hzf0ZSG5dhcvuSEvvrv2asIBkcrM4so7JCsk0GYeOGJFMJbOipTHM4ZMEuH5 pRzYYz6U3fU4pbhV4DpFja9iVlKUcwgWV17EF5HfX1gi4aojGOYblngqFB2QaiMSigCT 11GA== X-Gm-Message-State: AOAM53271JY829ibtvmAUoNLN6931Qc7VqVirCkO0QF8rXkdAC1VSRK8 3qI6ckkXV8zQ+zAU0/dh1u4Acb+zz4YQlA== X-Google-Smtp-Source: ABdhPJwVZHxt/a6dSWAsTyOkEioSt8CXwVEO4twGA2c7NvB4P9Za/BLQa44C1he44wywejOT9hADxg== X-Received: by 2002:a7b:c184:: with SMTP id y4mr2354321wmi.128.1632492393044; Fri, 24 Sep 2021 07:06:33 -0700 (PDT) Received: from [192.168.0.201] (bl22-100-144.dsl.telepac.pt. [2.83.100.144]) by smtp.gmail.com with ESMTPSA id z133sm15849414wmc.45.2021.09.24.07.06.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 07:06:32 -0700 (PDT) Subject: Re: [PATCH] gdbsupport: better detection of -Wmissing-prototypes support From: Pedro Alves To: Simon Marchi , Andrew Burgess , gdb-patches@sourceware.org References: <20210924122933.2714720-1-andrew.burgess@embecosm.com> <20210924131632.GC1900093@embecosm.com> <9ea18967-7c71-60a0-f265-a39634b335df@polymtl.ca> Message-ID: <54b146f8-f83b-67ea-d63f-ece07e7b7657@palves.net> Date: Fri, 24 Sep 2021 15:06:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <9ea18967-7c71-60a0-f265-a39634b335df@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-09-24 2:40 p.m., Simon Marchi via Gdb-patches wrote: > On 2021-09-24 9:16 a.m., Andrew Burgess wrote: >> It has been pointed out to me on IRC (thanks Simon), that this issue >> is not GCC, but ccache: >> >> https://github.com/ccache/ccache/issues/738#issuecomment-740133374 >> >> So this patch certainly shouldn't go in as it is currently written. >> >> It's still pretty annoying seeing those warnings though, so I wonder >> if we can consider having a work around for this ccache issue in the >> GDB configure scripts? >> >> Maybe something as simple as setting CCACHE_DISABLE in the environment >> prior to running the AM_GDB_WARNINGS checks? >> >> All ideas welcome... > > Either way would be fine with me: > > - to use AC_LINK_IFELSE all the time (I don't think the execution time > would be significantly higher) > - to set CCACHE_DISABLE during the execution of AM_GDB_WARNINGS Does working around this in configure tests still mean that when using ccache for really building gdb, ccache will still misreorder arguments and thus potentially a -Wmissing-prototypes warning would not be turned into an error? So, here's another option, I think: #3 - drop -Wmissing-prototypes completely. As the GCC warning says, cc1plus: warning: command line option ‘-Wmissing-prototypes’ is valid for C/ObjC but not for C++ it's only valid for C, not C++. Do we compile anything with a C compiler nowadays?