From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2647 invoked by alias); 9 Mar 2015 11:38:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2637 invoked by uid 89); 9 Mar 2015 11:38:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Mar 2015 11:38:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t29Bcsg3020711 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Mar 2015 07:38:55 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t29BcrbL007938; Mon, 9 Mar 2015 07:38:54 -0400 Message-ID: <54FD864D.8030403@redhat.com> Date: Mon, 09 Mar 2015 11:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [pushed] Fix struct sockaddr/sockaddr_in/sockaddr_un strict aliasing violations References: <1425750266-14385-1-git-send-email-palves@redhat.com> <83r3t0lmb9.fsf@gnu.org> <54FB4162.5090601@redhat.com> <83oao4ljwg.fsf@gnu.org> <54FD79B4.8070201@redhat.com> <54FD7F9D.9070809@redhat.com> In-Reply-To: <54FD7F9D.9070809@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00214.txt.bz2 On 03/09/2015 11:10 AM, Pedro Alves wrote: > With all that said, I'm having second thoughts on this ... Per > 6.3.2.3 ("A pointer to an object or incomplete type may be converted to > a pointer to a different object or incomplete type"), as long as we don't > actually access the fields of sockaddr through the "struct sockaddr *" pointer, > then the cast should be OK. In the bind/accept cast, it should be the > internals of those functions that need the union trick. Gosh, what a mess. > > So I'll revert the union patch, and apply the original one that added > the missing cast to tracepoint.c... Done. Sorry for the noise... Thanks, Pedro Alves