From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103642 invoked by alias); 6 Mar 2015 22:41:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103627 invoked by uid 89); 6 Mar 2015 22:41:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Mar 2015 22:41:23 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t26MfLdT005058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Mar 2015 17:41:21 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t26MfJZH018973; Fri, 6 Mar 2015 17:41:20 -0500 Message-ID: <54FA2D0F.7000108@redhat.com> Date: Fri, 06 Mar 2015 22:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: John Baldwin CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Use kinfo_getvmmap () on FreeBSD to enumerate memory regions. References: <1611123.gixn7rQRH9@ralph.baldwin.cx> <54FA04C3.5030405@redhat.com> <1897208.OU0R2xD82y@ralph.baldwin.cx> In-Reply-To: <1897208.OU0R2xD82y@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00188.txt.bz2 On 03/06/2015 09:06 PM, John Baldwin wrote: > On Friday, March 06, 2015 07:49:23 PM Pedro Alves wrote: >> Hi John, >> >> Looks good to me, with a few nits/suggestions below. >> >> On 02/26/2015 09:44 PM, John Baldwin wrote: >>> Use kinfo_getvmmap () from libutil on FreeBSD to enumerate memory >>> regions in a running process instead of /proc//map. FreeBSD systems >>> do not mount procfs by default, but kinfo_getvmmap () uses a sysctl that >>> is always available. >>> >>> Skip memory regions for devices as well as regions an application has >>> requested to not be dumped via the MAP_NOCORE flag to mmap () or >>> MADV_NOCORE advice to madvise (). >> >> Note that GNU's coding conventions tell us to refer to functions by >> name without the ()'s. > > Ok. > >>> gdb/ChangeLog: >>> * configure.ac: AC_CHECK_LIB(util, kinfo_getvmmap). >>> * configure: Regenerate. >>> * config.in: Regenerate. >>> * fbsd-nat.c (fbsd_find_memory_regions): Use kinfo_getvmmap to >>> enumerate memory regions if present. >> >> * fbsd-nat.c [!HAVE_KINFO_GETVMMAP] (fbsd_read_mapping): Don't >> define. >> (fbsd_find_memory_regions): Use kinfo_getvmmap to >> enumerate memory regions if present. > > Ok. > >>> --- >>> >>> gdb/configure.ac | 5 +++++ >>> gdb/fbsd-nat.c | 56 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files >>> changed, 61 insertions(+) >>> >>> diff --git a/gdb/configure.ac b/gdb/configure.ac >>> index 6ac8adb..b094164 100644 >>> --- a/gdb/configure.ac >>> +++ b/gdb/configure.ac >>> @@ -532,6 +532,11 @@ AM_ZLIB >>> >>> # On HP/UX we may need libxpdl for dlgetmodinfo (used by solib-pa64.c). >>> AC_SEARCH_LIBS(dlgetmodinfo, [dl xpdl]) >>> >>> +# On FreeBSD we may need libutil for kinfo_getvmmap (used by fbsd-nat.c). >>> +AC_CHECK_LIB(util, kinfo_getvmmap, >>> + [AC_DEFINE(HAVE_KINFO_GETVMMAP, 1, >>> + [Define to 1 if your system has the kinfo_getvmmap function. >>> ])]) + >> >> Isn't >> >> AC_SEARCH_LIBS(kinfo_getvmmap, [util]) >> >> pretty much the same? > > Might be, I wasn't sure from reading the autoconf docs that this would add the > appropriate define. I'll certainly try it and if it works I'm happier to use > the simpler form. > >> (Note: please make sure to use pristine GNU autoconf 2.64 when generating >> the files, to avoid spurious odd differences coming out. Some distros >> carry local patches that result in that, dunno about FreeBSD.) > > Yes, I had to download my own copy to use when I tested this locally. > >>> + vmentl = kinfo_getvmmap (pid, &nitems); >>> + if (vmentl == NULL) >>> + perror_with_name (_("Couldn't fetch VM map entries.")); >>> + cleanup = make_cleanup (free, vmentl); >> >> s/free/xfree/g. > > I wasn't sure about this one. kinfo_getvmmap() calls malloc() from libc > internally (so it isn't using xmalloc() to allocate the memory that is > returned). Is it still correct to use xfree() instead of free() in that case? Ah, I just saw bare "free" and didn't realize that it was kinfo_getvmmap that malloc the memory. Yeah, free is correct then. Sorry for the noise. > > > @@ -136,4 +191,5 @@ fbsd_find_memory_regions (struct target_ops *self, >>> >>> do_cleanups (cleanup); >>> return 0; >>> >>> +#endif >>> >>> } >> >> I'd suggest splitting fbsd_find_memory_regions in two instead of the >> big #if/#else/#endif, but that's just personal preference. > > Do you mean an #if/#else/#endif around the entire function vs just the body or > do you mean something else? If the former, I can easily do that (and collapse > down to on #if/#else/#endif with the prior conditionally-defined function). Yeah, that. Thanks, Pedro Alves