From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107491 invoked by alias); 4 Mar 2015 17:22:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107478 invoked by uid 89); 4 Mar 2015 17:22:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Mar 2015 17:22:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t24HLupu025085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Mar 2015 12:21:57 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t24HLsd4017405; Wed, 4 Mar 2015 12:21:55 -0500 Message-ID: <54F73F32.6070102@redhat.com> Date: Wed, 04 Mar 2015 17:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Wei-cheng Wang , uweigand@de.ibm.com, gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Fast tracepoint for powerpc64le References: <54E77725.2070707@gmail.com> In-Reply-To: <54E77725.2070707@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00131.txt.bz2 On 02/20/2015 06:04 PM, Wei-cheng Wang wrote: > +/* Return the value of register REGNUM. RAW_REGS is collected buffer > + by jump pad. This function is called by emit_reg. */ > + > +ULONGEST __attribute__ ((visibility("default"), used)) > +gdb_agent_get_raw_reg (const unsigned char *raw_regs, int regnum) > +{ > + if (regnum >= PPC_NUM_FT_COLLECT_GREGS) Meanwhile several C++ patches landed which changed how this function should be declared. Please make this: IP_AGENT_EXPORT_FUNC ULONGEST gdb_agent_get_raw_reg (const unsigned char *raw_regs, int regnum) { I think it'd be good to split out the changes that make ppc gdbserver do Z0 packets too. (nit: it'd make it easier to identify the different patches in the series if they had different subjects, which identified their actual contents. That's ideal for the subjects of the git commits too, so best do that when submitting the patches already.) Thanks for working on this! Pedro Alves