From: Simon Marchi <simon.marchi@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove unused function declarations in target.h
Date: Tue, 03 Mar 2015 22:40:00 -0000 [thread overview]
Message-ID: <54F6383D.8050009@ericsson.com> (raw)
In-Reply-To: <54F63793.1000709@gmail.com>
On 03/03/2015 05:37 PM, Yao Qi wrote:
> Hi Simon,
>
> On 03/03/2015 05:59 PM, Simon Marchi wrote:
>> gdb/ChangeLog:
>>
>> * target.h: Remove find_default_create_inferior and
>> find_default_attach.
>
> I prefer to rewrite it in this way,
>
> * target.h (find_default_create_inferior): Remove declaration.
> (find_default_attach): Likewise.
>
> The patch is OK.
Agreed, it's nicer that way.
Pushed, thanks!
prev parent reply other threads:[~2015-03-03 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 17:59 Simon Marchi
2015-03-03 22:37 ` Yao Qi
2015-03-03 22:40 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F6383D.8050009@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox