Re: [PATCH] btrace: avoid tp != NULL assertion

[Pedro Alves <palves@redhat.com>]

On 03/03/2015 01:55 PM, Metzger, Markus T wrote:
>> -----Original Message-----
>> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
>> owner@sourceware.org] On Behalf Of Pedro Alves
>> Sent: Tuesday, March 3, 2015 2:42 PM
>> To: Metzger, Markus T
>> Cc: gdb-patches@sourceware.org
>> Subject: Re: [PATCH] btrace: avoid tp != NULL assertion
> 
> 
>>> No, that wasn't the reason for replacing the assert.  There are no such
>>> errors in the gdb.btrace suite (which is mostly single-threaded) with my
>>> patch and I have not seen any such errors otherwise, either.
>>
>> Then it sounds like we're either lacking basic tests, or the threaded tests
>> are somehow not running correctly when gdb is a 32-bit program.  I think
>> that if you step any non-leader thread, you should see it happen.
>> Grepping the tests, I think gdb.btrace/multi-thread-step.exp should have
>> caught it.  My machine doesn't do btrace, so I can't try it myself...
>>
>> BTW, did any existing test in the testsuite catch the assertion we're
>> fixing?
> 
> Almost all of them when run on 32-bit systems; -m32 on 64-bit systems does
> not catch this.

Right, that's why I said "when gdb is a 32-bit program".  Sounds like
no existing test tries a "step" when not replaying then.  It'd be very
nice to have one.  Can I convince you to add one?  :-)

Thanks,
Pedro Alves