From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92933 invoked by alias); 28 Feb 2015 00:09:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92924 invoked by uid 89); 28 Feb 2015 00:09:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 28 Feb 2015 00:09:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1S09enc025580 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2015 19:09:40 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1S09dfd002182; Fri, 27 Feb 2015 19:09:39 -0500 Message-ID: <54F10742.1070605@redhat.com> Date: Sat, 28 Feb 2015 00:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 00/36] Support building GDB as a C++ program References: <1423524046-20605-1-git-send-email-palves@redhat.com> <54F0B52F.1050909@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00846.txt.bz2 On 02/27/2015 11:51 PM, Patrick Palka wrote: > On Fri, Feb 27, 2015 at 1:19 PM, Pedro Alves wrote: >> I didn't push this one, as it introduces an aliasing violation: >> >> > [PATCH 20/36] gdbserver/tracepoint: Add cast sockaddr_un/sockaddr cast >> These are still pending: >> >> > [PATCH 29/36] Normalize TRY_CATCH exception handling block >> > [PATCH 30/36] quit_force: Replace TRY_CATCH wrapper macros >> > [PATCH 31/36] Split TRY_CATCH into TRY + CATCH >> > [PATCH 32/36] TRY_CATCH -> TRY+CATCH+END_CATCH everywhere >> > [PATCH 33/36] TRY_CATCH -> TRY+CATCH+END_CATCH, the manual conversions >> > [PATCH 34/36] more making TRY/CATCH callers look more like real C++ try/catch blocks >> > [PATCH 35/36] kill volatile struct gdb_exception >> > [PATCH 36/36] Make TRY/CATCH use real C++ try/catch in C++ mode >> >> I don't have time right now to rebase this part, but I'd like >> to move ahead with it sometime soon. If anyone has comments on >> this, now's the time to send them out. > Is GDB supposed to build yet with --enable-build-with-cxx? I am > currently getting a slew of errors and warnings when building GDB with > G++ 4.9.1. No, not until all the pending patches above are pushed. Patch 20 needs to be rewritten using the union trick instead of the invalid cast (strict aliasing violation) -- help with that much appreciated! :-) Googling for strict aliasing and sockaddr should find a ton of examples. Even when this series is fully pushed, you'll still get a slew of warnings due to invalid C++ code that G++ is allowing anyway due to the -fpermissive shortcut. Things like 'char *str = xmalloc (size);' need a cast in C++, but -fpermissive downgrades that error to a warning. As there's no way to suppress those warnings, for now C++ mode doesn't enable -Werror. The follow up part 2 series that I mentioned fixes all those warnings. Thanks, Pedro Alves