From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58697 invoked by alias); 27 Feb 2015 14:47:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58677 invoked by uid 89); 27 Feb 2015 14:47:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Feb 2015 14:47:29 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1RElPGU020928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2015 09:47:25 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1RElNYd030521; Fri, 27 Feb 2015 09:47:24 -0500 Message-ID: <54F0837A.1050707@redhat.com> Date: Fri, 27 Feb 2015 14:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii CC: qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [pushed] Add "../lib/unbuffer_output.c" and use it in gdb.base/interrupt.c (Re: [PATCH 5/6] testsuite: Introduce $inferior_spawn_id) References: <1424699660-11727-1-git-send-email-palves@redhat.com> <1424699660-11727-6-git-send-email-palves@redhat.com> <867fv7xodw.fsf@gmail.com> <54F04A2B.5@redhat.com> <54F04E16.2070704@redhat.com> <54F05F2C.5020007@gmail.com> <54F07829.9030009@redhat.com> <83zj7z4dqd.fsf@gnu.org> In-Reply-To: <83zj7z4dqd.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00824.txt.bz2 On 02/27/2015 02:43 PM, Eli Zaretskii wrote: >> Date: Fri, 27 Feb 2015 13:59:05 +0000 >> From: Pedro Alves >> CC: gdb-patches@sourceware.org >> >>>> + Windows pipe, thus not a tty and its outputs ends up fully >>>> + buffered. */ >>>> +#ifndef __MINGW32__ >>>> + if (!isatty (fileno (stdin))) >>>> +#endif >>> >>> Include unistd.h for isatty? >>> >> >> ... with these fixed. >> >> Do you want to comment on the rest of the series, or shall I push it? > > If that's isatty from the MS runtime, it will return non-zero for > every character device, including the null device. Is that what we > want here? No, and so we skip the isatty check on Windows. Note the #ifndef. Thanks, Pedro Alves