From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66011 invoked by alias); 27 Feb 2015 13:59:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65996 invoked by uid 89); 27 Feb 2015 13:59:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Feb 2015 13:59:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1RDx761010801 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2015 08:59:07 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1RDx6rZ024238; Fri, 27 Feb 2015 08:59:06 -0500 Message-ID: <54F07829.9030009@redhat.com> Date: Fri, 27 Feb 2015 13:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: [pushed] Add "../lib/unbuffer_output.c" and use it in gdb.base/interrupt.c (Re: [PATCH 5/6] testsuite: Introduce $inferior_spawn_id) References: <1424699660-11727-1-git-send-email-palves@redhat.com> <1424699660-11727-6-git-send-email-palves@redhat.com> <867fv7xodw.fsf@gmail.com> <54F04A2B.5@redhat.com> <54F04E16.2070704@redhat.com> <54F05F2C.5020007@gmail.com> In-Reply-To: <54F05F2C.5020007@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00819.txt.bz2 On 02/27/2015 12:12 PM, Yao Qi wrote: > Hi Pedro, > This patch is fine by me. Awesome, patch below is pushed... > On 27/02/15 10:59, Pedro Alves wrote: >> + /* Always force this for Windows testing. To a native Windows >> + program running under under a Cygwin shell/ssh, stdin is really a > > Double "under". > >> + Windows pipe, thus not a tty and its outputs ends up fully >> + buffered. */ >> +#ifndef __MINGW32__ >> + if (!isatty (fileno (stdin))) >> +#endif > > Include unistd.h for isatty? > ... with these fixed. Do you want to comment on the rest of the series, or shall I push it? ---- >From 6f98576f29a70ed947f102015df0388bccc6aa1a Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 27 Feb 2015 13:54:22 +0000 Subject: [PATCH] Add "../lib/unbuffer_output.c" and use it in gdb.base/interrupt.c In some scenarios, GDB or GDBserver can be spawned with input _not_ connected to a tty, and then tests that rely on stdio fail with timeouts, because the inferior's stdout and stderr streams end up fully buffered. See discussion here: https://sourceware.org/ml/gdb-patches/2015-02/msg00809.html We have a hack in place that works around this for Windows testing, that forces every test program to link with an .o file that does (lib/set_unbuffered_mode.c): static int __gdb_set_unbuffered_output (void) __attribute__ ((constructor)); static int __gdb_set_unbuffered_output (void) { setvbuf (stdout, NULL, _IONBF, BUFSIZ); setvbuf (stderr, NULL, _IONBF, BUFSIZ); } That's a bit hacky; it ends up done for _all_ tests. This patch adds a way to do this unbuffering explicitly from the test code itself, so it is done only when necessary, and for all targets/hosts. For starters, it adjusts gdb.base/interrupt.c to use it. Tested on x86_64 Fedora 20, native, and against a remote gdbserver board file that connects to the target with ssh, with and without -t (create pty). gdb/testsuite/ 2015-02-27 Pedro Alves * lib/unbuffer_output.c: New file. * gdb.base/interrupt.c: Include "../lib/unbuffer_output.c". (main): Call gdb_unbuffer_output. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.base/interrupt.c | 5 +++++ gdb/testsuite/lib/unbuffer_output.c | 39 +++++++++++++++++++++++++++++++++++++ 3 files changed, 50 insertions(+) create mode 100644 gdb/testsuite/lib/unbuffer_output.c diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a5896be..efc74f6 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2015-02-27 Pedro Alves + + * lib/unbuffer_output.c: New file. + * gdb.base/interrupt.c: Include "../lib/unbuffer_output.c". + (main): Call gdb_unbuffer_output. + 2015-02-27 Yao Qi * gdb.base/catch-syscall.exp: Don't skip it on hppa*-hp-hpux* diff --git a/gdb/testsuite/gdb.base/interrupt.c b/gdb/testsuite/gdb.base/interrupt.c index d7bb271..6426015 100644 --- a/gdb/testsuite/gdb.base/interrupt.c +++ b/gdb/testsuite/gdb.base/interrupt.c @@ -3,6 +3,8 @@ #include #include +#include "../lib/unbuffer_output.c" + #ifdef SIGNALS #include @@ -17,6 +19,9 @@ main () { char x; int nbytes; + + gdb_unbuffer_output (); + #ifdef SIGNALS signal (SIGINT, sigint_handler); #endif diff --git a/gdb/testsuite/lib/unbuffer_output.c b/gdb/testsuite/lib/unbuffer_output.c new file mode 100644 index 0000000..5093299 --- /dev/null +++ b/gdb/testsuite/lib/unbuffer_output.c @@ -0,0 +1,39 @@ +/* Copyright (C) 2008-2015 Free Software Foundation, Inc. + + This file is part of GDB. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +/* Force output to unbuffered mode if not connected to a terminal. */ + +#include +#ifndef __MINGW32__ +#include +#endif + +static int +gdb_unbuffer_output (void) +{ + /* Always force this for Windows testing. To a native Windows + program running under a Cygwin shell/ssh, stdin is really a + Windows pipe, thus not a tty and its outputs ends up fully + buffered. */ +#ifndef __MINGW32__ + if (!isatty (fileno (stdin))) +#endif + { + setvbuf (stdout, NULL, _IONBF, BUFSIZ); + setvbuf (stderr, NULL, _IONBF, BUFSIZ); + } +} -- 1.9.3