From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71031 invoked by alias); 27 Feb 2015 09:50:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71012 invoked by uid 89); 27 Feb 2015 09:50:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Feb 2015 09:50:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1R9oJLp018274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Feb 2015 04:50:19 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1R9oH9q030968; Fri, 27 Feb 2015 04:50:17 -0500 Message-ID: <54F03DD8.8080902@redhat.com> Date: Fri, 27 Feb 2015 09:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joel Brobecker , gdb-patches@sourceware.org CC: Mark Wielaard Subject: Re: [RFA/commit] Remove use of stdbool.h in GDB sources. References: <1425027226-23546-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1425027226-23546-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00807.txt.bz2 On 02/27/2015 08:53 AM, Joel Brobecker wrote: > Hello, > > Using type bool from stdbool unfortunately causes problems trying > to build GDB on AiX and Solaris: Darn... > But, thinking beyond this very specific issue, it shows that using > stdbool.h is going to cause problems on these systems until either > GCC fixes those includes in a way that makes them work (not really > an option in the short term); or we switch to C++. > > In the meantime, I think the path of least resistance is to revert > the use of stdbool.h, and use integers, the way we've done up until > now. The benefits of using type "bool" are modest, IMO, so not > a great loss, and a temporary one. I agree. > > gdb/ChangeLog: > > * utils.h: Remove #include. > (producer_is_gcc): Change return type to "int". > * utils.c (producer_is_gcc): Change return type to int. > Return 1 instead of true, and 0 instead of false. > Adjust function documentation accordingly. > > I will push this patch in the next few days, unless there are > objections. No objections here. (guess we should reinstate the ARI bool rule too then.) Thanks, Pedro Alves