Re: [PATCH] Enable building GDB without installed libtermcap

Pedro Alves
2015-02-23T16:18:21Z

On 02/23/2015 04:05 PM, Pedro Alves wrote:

>> The idea for this patch is to include a simple version of libtermcap as a fall-back
>> for the case that the host compiler does not have any cursor library. This enables
>> at least a non tui-enabled gdb. It works even if there is no termcap configuration
>> file on the target. If a termcap or curses library can be found when configuring gdb,
>> we will use the installed library instead of the included libtermcap.

...

> I don't see any change to libtermcap that makes this a "simple version of libtermcap".
> AFAICS, this is really libtermcap, minus the manual and the definitions. Parts of
> the libtermcap patch you show look like something that really should be sent
> to libtermcap's list, even.

...

> Sorry, without a better rationale, I don't see how this makes sense. We
> like to have _fewer_ copies of upstream projects in the repo (such as
> e.g., readline), not more.

I should have added that GDB _already_ has a very minimal termcap in
the tree -- see gdb/windows-termcap.c. We could consider making that
the fallback on all hosts.

Thanks,
Pedro Alves