From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-120252-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 84541 invoked by alias); 26 Feb 2015 15:49:53 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 84511 invoked by uid 89); 26 Feb 2015 15:49:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Feb 2015 15:49:52 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1QFnpcR013310	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL)	for <gdb-patches@sourceware.org>; Thu, 26 Feb 2015 10:49:51 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1QFnmsJ015173;	Thu, 26 Feb 2015 10:49:50 -0500
Message-ID: <54EF409C.9090102@redhat.com>
Date: Thu, 26 Feb 2015 15:49:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
CC: Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [patchv2] compile: Fix GNU-IFUNC funcs called from injected code
References: <20150224190720.GA32497@host1.jankratochvil.net> <20150224200237.GA1746@host1.jankratochvil.net>
In-Reply-To: <20150224200237.GA1746@host1.jankratochvil.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-02/txt/msg00765.txt.bz2

On 02/24/2015 08:02 PM, Jan Kratochvil wrote:
> 
> gdb/ChangeLog
> 2015-02-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* compile/compile-c-symbols.c (convert_one_symbol, convert_symbol_bmsym)
> 	(gcc_symbol_address): Call gnu_ifunc_resolve_addr.

Looks good to me too.  OK.

I think we could probably avoid the extra infcall done
within gnu_ifunc_resolve_addr if we're going to be running
the generated code anyway, but it's not worth the effort
at this point.

> +if { [prepare_for_testing ${testfile}.exp "$testfile-debug" $srcfile] } {
> +    return -1
> +}
> +
> +if ![runto_main] {
> +    return -1
> +}
> +

Could you move these inside the prefix too, so that if they
fail for some reason, we get distinct test messages from
the nodebug case?

> +with_test_prefix "debug" {

Thanks,
Pedro Alves