From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47613 invoked by alias); 26 Feb 2015 13:59:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47596 invoked by uid 89); 26 Feb 2015 13:59:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 X-HELO: out1-smtp.messagingengine.com Received: from out1-smtp.messagingengine.com (HELO out1-smtp.messagingengine.com) (66.111.4.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 26 Feb 2015 13:59:25 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 267D42090F for ; Thu, 26 Feb 2015 08:59:22 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Thu, 26 Feb 2015 08:59:23 -0500 Received: from [192.168.1.102] (unknown [31.51.205.191]) by mail.messagingengine.com (Postfix) with ESMTPA id 7572D680171; Thu, 26 Feb 2015 08:59:22 -0500 (EST) Message-ID: <54EF26B8.8030602@dronecode.org.uk> Date: Thu, 26 Feb 2015 13:59:00 -0000 From: Jon TURNEY User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Retrieve segment registers on Windows amd64 References: <1424435625-3708-1-git-send-email-jon.turney@dronecode.org.uk> <20150226092333.GB31815@adacore.com> In-Reply-To: <20150226092333.GB31815@adacore.com> Content-Type: multipart/mixed; boundary="------------030905070602080400070303" X-SW-Source: 2015-02/txt/msg00759.txt.bz2 This is a multi-part message in MIME format. --------------030905070602080400070303 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 730 On 26/02/2015 09:23, Joel Brobecker wrote: > Thanks for the patch. > > The patch looks good to me. > The ChangeLog needs to identify all the changes were made, and in > particular, it needs to mention the fact that CONTEXT_DEBUGGER's > declaration was removed. Thanks for taking a look. Patch with ChangeLog amended as you suggest attached. > Do you have a GDB copyright assignment on file. The patch is small > enough that we can take it as a "tiny patch", but if you have other > patches in the pipeline, then you'll eventually need to fill one out. > Let me know if you'd like to get started on the process, it takes > a few weeks to complete, as I understand it. Hopefully, I will have a few more patches, so yes please. --------------030905070602080400070303 Content-Type: text/plain; charset=windows-1252; name="0001-Retrieve-segment-registers-on-Windows-amd64.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Retrieve-segment-registers-on-Windows-amd64.patch" Content-length: 2648 RnJvbSAzOGM0YTBlYmQ1MGNiY2IyNjMwZDUwYmU2MzNhYjFmOWM5MTA3MTAw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gVFVSTkVZIDxq b24udHVybmV5QGRyb25lY29kZS5vcmcudWs+CkRhdGU6IFdlZCwgMTggRmVi IDIwMTUgMjM6MTM6NDcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBSZXRyaWV2 ZSBzZWdtZW50IHJlZ2lzdGVycyBvbiBXaW5kb3dzIGFtZDY0CgpGb3IgYW1k NjQsIENPTlRFWFRfRlVMTCBkb2VzIG5vdCBjb250YWluIENPTlRFWFRfU0VH TUVOVFMsIHdoaWNoIHNlZW1zIHRvIGJlCm5lZWRlZCB0byByZXRyaWV2ZSBh bGwgdGhlIHNlZ21lbnQgcmVnaXN0ZXJzLiAgQWRkIGl0IGV4cGxpY2l0bHks IHdpdGggYSBsaXR0bGUKZGUtY3J1ZnRpZmljYXRpb24uCgpUaGUgdmFsdWUg b2YgdGhlIHNlZ21lbnQgcmVnaXN0ZXJzIGlzbid0IHRlcnJpYmx5IHVzZWZ1 bCBvbiBhbWQ2NCwgYnV0IGF0IGxlYXN0CnRoaXMgbWFrZXMgdGhlIG91dHB1 dCBvZiAnaW5mbyByZWdpc3RlcnMnIGNvcnJlY3QuCgpiZWZvcmU6CgooZ2Ri KSAgaSByIGNzIHNzIGRzIGVzIGZzIGdzCmNzICAgICAgICAgICAgIDB4MzMg ICAgIDUxCnNzICAgICAgICAgICAgIDB4MmIgICAgIDQzCmRzICAgICAgICAg ICAgIDB4MCAgICAgIDAKZXMgICAgICAgICAgICAgMHgwICAgICAgMApmcyAg ICAgICAgICAgICAweDAgICAgICAwCmdzICAgICAgICAgICAgIDB4MCAgICAg IDAKCmFmdGVyOgoKKGdkYikgaSByIGNzIHNzIGRzIGVzIGZzIGdzCmNzICAg ICAgICAgICAgIDB4MzMgICAgIDUxCnNzICAgICAgICAgICAgIDB4MmIgICAg IDQzCmRzICAgICAgICAgICAgIDB4MmIgICAgIDQzCmVzICAgICAgICAgICAg IDB4MmIgICAgIDQzCmZzICAgICAgICAgICAgIDB4NTMgICAgIDgzCmdzICAg ICAgICAgICAgIDB4MmIgICAgIDQzCgpnZGIvQ2hhbmdlTG9nCgoyMDE1LTAy LTI2ICBKb24gVFVSTkVZICA8am9uLnR1cm5leUBkcm9uZWNvZGUub3JnLnVr PgoKCSogd2luZG93cy1uYXQuYyAoQ09OVEVYVF9ERUJVR0dFUik6IFJlbW92 ZS4KCShDT05URVhUX0RFQlVHR0VSX0RSKTogQWRkIENPTlRFWFRfU0VHTUVO VFMuICBJbmNvcnBvcmF0ZSBmbGFncwoJZnJvbSBDT05URVhUX0RFQlVHR0VS LgotLS0KIGdkYi93aW5kb3dzLW5hdC5jIHwgNSArKy0tLQogMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9nZGIvd2luZG93cy1uYXQuYyBiL2dkYi93aW5kb3dzLW5hdC5j CmluZGV4IDljMmRjYTEuLmVjMTE4MjIgMTAwNjQ0Ci0tLSBhL2dkYi93aW5k b3dzLW5hdC5jCisrKyBiL2dkYi93aW5kb3dzLW5hdC5jCkBAIC0xMzAsNyAr MTMwLDYgQEAgc3RhdGljIENPTlRFWFQgc2F2ZWRfY29udGV4dDsJLyogQ29u dGFpbmVzIHRoZSBzYXZlZCBjb250ZXh0IGZyb20gYQogZW51bQogICB7CiAg ICAgRkxBR19UUkFDRV9CSVQgPSAweDEwMCwKLSAgICBDT05URVhUX0RFQlVH R0VSID0gKENPTlRFWFRfRlVMTCB8IENPTlRFWFRfRkxPQVRJTkdfUE9JTlQp CiAgIH07CiAjZW5kaWYKIApAQCAtMTQwLDggKzEzOSw4IEBAIGVudW0KICNk ZWZpbmUgQ09OVEVYVF9FWFRFTkRFRF9SRUdJU1RFUlMgMAogI2VuZGlmCiAK LSNkZWZpbmUgQ09OVEVYVF9ERUJVR0dFUl9EUiBDT05URVhUX0RFQlVHR0VS IHwgQ09OVEVYVF9ERUJVR19SRUdJU1RFUlMgXAotCXwgQ09OVEVYVF9FWFRF TkRFRF9SRUdJU1RFUlMKKyNkZWZpbmUgQ09OVEVYVF9ERUJVR0dFUl9EUiBD T05URVhUX0ZVTEwgfCBDT05URVhUX0ZMT0FUSU5HX1BPSU5UIFwKKyAgICAg ICAgfCBDT05URVhUX1NFR01FTlRTIHwgQ09OVEVYVF9ERUJVR19SRUdJU1RF UlMgfCBDT05URVhUX0VYVEVOREVEX1JFR0lTVEVSUwogCiBzdGF0aWMgdWlu dHB0cl90IGRyWzhdOwogc3RhdGljIGludCBkZWJ1Z19yZWdpc3RlcnNfY2hh bmdlZDsKLS0gCjIuMS40Cgo= --------------030905070602080400070303--