From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19124 invoked by alias); 25 Feb 2015 08:20:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19109 invoked by uid 89); 25 Feb 2015 08:20:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 25 Feb 2015 08:20:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1P8KVrr002210 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 25 Feb 2015 03:20:31 -0500 Received: from localhost.localdomain (ovpn-112-21.ams2.redhat.com [10.36.112.21]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1P8KTSO024324; Wed, 25 Feb 2015 03:20:30 -0500 Message-ID: <54ED85CC.7030506@redhat.com> Date: Wed, 25 Feb 2015 08:20:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patchv2] compile: Fix GNU-IFUNC funcs called from injected code References: <20150224190720.GA32497@host1.jankratochvil.net> <20150224200237.GA1746@host1.jankratochvil.net> In-Reply-To: <20150224200237.GA1746@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00704.txt.bz2 On 24/02/15 20:02, Jan Kratochvil wrote: > Testcase cosmetic update. > > compile-gnu-ifunc2.patch > > gdb/ChangeLog > 2015-02-24 Jan Kratochvil > > * compile/compile-c-symbols.c (convert_one_symbol, convert_symbol_bmsym) > (gcc_symbol_address): Call gnu_ifunc_resolve_addr. > > gdb/testsuite/ChangeLog > 2015-02-24 Jan Kratochvil > > * gdb.compile/compile-ifunc.c: New file. > * gdb.compile/compile-ifunc.exp: New file. Thanks. This looks great other than the following nit: > case mst_text_gnu_ifunc: > - type = objfile_type (objfile)->nodebug_text_gnu_ifunc_symbol; > + // nodebug_text_gnu_ifunc_symbol would cause: > + // function return type cannot be function Not sure if we allow // comments yet. > + if (TYPE_GNU_IFUNC (SYMBOL_TYPE (sym))) > + result = gnu_ifunc_resolve_addr (target_gdbarch (), result); Is this guaranteed to return a value to result (or an exception)? Cheers Phil