From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17709 invoked by alias); 23 Feb 2015 16:06:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17454 invoked by uid 89); 23 Feb 2015 16:06:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 23 Feb 2015 16:06:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1NG5tls009090 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 23 Feb 2015 11:05:56 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1NG5pcN030085; Mon, 23 Feb 2015 11:05:52 -0500 Message-ID: <54EB4FDF.1060909@redhat.com> Date: Mon, 23 Feb 2015 16:06:00 -0000 From: Pedro Alves Reply-To: GDB Patches User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Bernd Edlinger CC: GDB Patches , "binutils@sourceware.org" Subject: Re: [PATCH] Enable building GDB without installed libtermcap References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00667.txt.bz2 Moving to gdb-patches@sourceware.org. Please keep replies there. On 02/22/2015 03:11 AM, Bernd Edlinger wrote: > Hi, > > currently building gdb is impossible without an installed termcap or a curses library. > That can be rather aw-quad when building a gdb for a build != host configuration. Hmm, but how is that different from any other dependency? > The idea for this patch is to include a simple version of libtermcap as a fall-back > for the case that the host compiler does not have any cursor library. This enables > at least a non tui-enabled gdb. It works even if there is no termcap configuration > file on the target. If a termcap or curses library can be found when configuring gdb, > we will use the installed library instead of the included libtermcap. > > I used the latest available GNU libtermcap-1.3.1 from http://ftp.gnu.org/gnu/termcap/, > refreshed the autoconf files and integrated that in the gdb build system. I don't see any change to libtermcap that makes this a "simple version of libtermcap". AFAICS, this is really libtermcap, minus the manual and the definitions. Parts of the libtermcap patch you show look like something that really should be sent to libtermcap's list, even. > I verified that this patch builds various cross-configurations, including target=cygwin. > > To keep the patch files below the limit of 400K for this newsgroup, the attached patch > assumes that termcap-1.3.1 is first copied to the folder binutils-gdb/libtermcap. > The texinfo files termcap.info.* need to be manually deleted, as they can be regenerated. > Then the patch file patch-libtermcap.diff needs to be applied on the libtermcap folder, > and then autoconf 2.64 needs to be done on the libtermcap folder. Finally the > patch file patch-gdb-termcap.diff needs to be applied on the binutils-gdb folder. > > > OK for trunk? Sorry, without a better rationale, I don't see how this makes sense. We like to have _fewer_ copies of upstream projects in the repo (such as e.g., readline), not more. Thanks, Pedro Alves