From: Chen Gang S <gang.chen@sunrus.com.cn>
To: Pedro Alves <palves@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim/ChangeLog: Correct the related items' position and format.
Date: Thu, 19 Feb 2015 12:12:00 -0000 [thread overview]
Message-ID: <54E5D4E4.7060301@sunrus.com.cn> (raw)
In-Reply-To: <54E5CD7B.2080306@redhat.com>
On 2/19/15 19:48, Pedro Alves wrote:
> On 02/19/2015 11:48 AM, Chen Gang S wrote:
>> On 2/19/15 19:01, Pedro Alves wrote:
>>> On 02/19/2015 02:22 AM, Mike Frysinger wrote:
>>>> On 19 Feb 2015 09:06, Chen Gang S wrote:
>>>>> --- a/sim/ChangeLog
>>>>> +++ b/sim/ChangeLog
>>>>>
>>>>> + * ChangeLog: Move sub-modules related items to their own
>>>>> + ChangeLogs.
>>>>
>>>> heh, so meta. i'm not sure we generally do this ... does anyone else have input
>>>> here ?
>>>
>>> Yeah. ChangeLog changes don't get mentioned in ChangeLog.
>>>
>>
>> OK, thanks, I guess your meaning is "If we only change the ChangeLog
>> contents, we don't need additional ChangeLog comment for it.". e.g. in
>> our case, we don't need the contents below (they need to be removed when
>> I send patch v2):
>
> Right. To be super clear, drop the "only":
>
> "If we change the ChangeLog contents, we don't need additional ChangeLog comment for it."
>
OK, thanks. What you said sounds a little more preciser.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2015-02-19 12:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 0:59 Chen Gang S
2015-02-19 2:22 ` Mike Frysinger
2015-02-19 11:01 ` Pedro Alves
2015-02-19 11:40 ` Chen Gang S
2015-02-19 11:48 ` Pedro Alves
2015-02-19 12:12 ` Chen Gang S [this message]
2015-02-19 15:56 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E5D4E4.7060301@sunrus.com.cn \
--to=gang.chen@sunrus.com.cn \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox