Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().

Mike Frysinger
2015-02-17T10:34:29Z

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On 31 Jan 2015 07:07, Chen Gang S wrote:
> --- a/sim/ChangeLog
> +++ b/sim/ChangeLog
> @@ -1,5 +1,10 @@
> 2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>
>
> + * microblaze/interp.c (sim_do_command): Call freeargv() before
> + return.

this should be in sim/microblaze/ChangeLog instead. it looks like your last 4
entries in sim/ChangeLog need to get relocated. please do so.

while you're there, you should also fix your gentmap.c entry in
sim/common/ChangeLog -- only one space after the * is used.

as for the actual code, lgtm. thanks for fixing up the various error paths.
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]