From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19239 invoked by alias); 18 Feb 2015 14:41:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19229 invoked by uid 89); 18 Feb 2015 14:41:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: bin-vsp-out-05.atm.binero.net Received: from vsp-authed01.binero.net (HELO bin-vsp-out-05.atm.binero.net) (195.74.38.224) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Feb 2015 14:41:00 +0000 X-Halon-ID: 38fac7e4-b77c-11e4-a613-005056916f53 Authorized-sender: jiri@gaisler.se Received: from [192.168.1.20] (unknown [78.68.173.120]) by bin-vsp-out-05.atm.binero.net (Halon Mail Gateway) with ESMTPA for ; Wed, 18 Feb 2015 15:41:28 +0100 (CET) Message-ID: <54E4A477.1010706@gaisler.se> Date: Wed, 18 Feb 2015 14:41:00 -0000 From: Jiri Gaisler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH 09/23] sim/erc32: removed type mismatch compiler warnings References: <1424159099-5148-1-git-send-email-jiri@gaisler.se> <1424159099-5148-10-git-send-email-jiri@gaisler.se> <20150217091036.GM20008@vapier> In-Reply-To: <20150217091036.GM20008@vapier> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="X26OC68Tt4u7fCoN96aMb6FuF8JwxeLFX" X-SW-Source: 2015-02/txt/msg00480.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --X26OC68Tt4u7fCoN96aMb6FuF8JwxeLFX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 454 On 02/17/2015 10:10 AM, Mike Frysinger wrote: > On 17 Feb 2015 08:44, Jiri Gaisler wrote: >> --- a/sim/erc32/func.c >> +++ b/sim/erc32/func.c >> >> - fgets(lbuf, 1023, fp); >> + tmp =3D fgets(lbuf, 1023, fp); >=20 > not a new issue, but fgets needs to die in a fire. getline is a trivial = API and=20 > does a lot of nice stuff for you :). > -mike >=20 I thought fgets was secure, as it cannot write past the (statically) alloca= ted buffer. Jiri. --X26OC68Tt4u7fCoN96aMb6FuF8JwxeLFX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 884 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJU5KR3AAoJEIAIwBKmO2+bzXAQANP/VmmOm3wdufg08QM8r9Wn pDPOmCsMZ8vPxap9sok+6t/9e+/zeI8mNUN+eKudt9f7srSoZriqcXF0KmnImnxG uhO8ualWLXfoc0h/KcJvXzjZP/IIH7+COMKYyjqxxztQsQ4FYWdXhx6C5L23e6bw DAu1L24mF8xKn86MklNSfviwQw5ueGi89Z1H3DTTzFJLB3xCVbousDH2CNVCczhQ ZoLpNjYzCuPiUqx55iQ6QaoCleficc30v70YtCBtD9/Ho8ev4Im9nN7yNPLrJg0T dobQDmGAurAAkmU1/gkxm1WruleC0gRE0Yn40Q17LY0SE9D6OCDLHKkYHLBQFXZR JEbJP1g+zwaucbl1vHtBfuE1R4fqY4Fg3BowtmwOuPSfsYJE03b/Slih5+Q36X61 5l6E53y+oSO5wdvYKNSab+0Bx22rI+8TuYKhqrYmOHqjzcNn5V/V16ZIXfVBuUpb N5qvMi/ls3qbb+BxzDaLuaG5226jUV/P/B1kxD+2aYTZ9XNKp8kWxizgyxqKrxql WzwhxjtGOIyZLAXVq9ytrm4WHnyN1NBkKvtWtdQKA4aTEv9A5BNewJtd8tdL+ndi IsW7HSUhERp0qUW4q8Fa58nK2GWTP78sglnKhPuc647XztJTKZjopPSTb4A4CP7U ZhE94ZELBuDQOcWDrNwf =odqR -----END PGP SIGNATURE----- --X26OC68Tt4u7fCoN96aMb6FuF8JwxeLFX--