From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21761 invoked by alias); 17 Feb 2015 08:01:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20702 invoked by uid 89); 17 Feb 2015 08:01:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailout1.w1.samsung.com Received: from mailout1.w1.samsung.com (HELO mailout1.w1.samsung.com) (210.118.77.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (DES-CBC3-SHA encrypted) ESMTPS; Tue, 17 Feb 2015 08:00:58 +0000 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJW006C2P4DTI50@mailout1.w1.samsung.com> for gdb-patches@sourceware.org; Tue, 17 Feb 2015 08:05:01 +0000 (GMT) Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id C1.5C.07834.5A4F2E45; Tue, 17 Feb 2015 07:58:29 +0000 (GMT) Received: from [106.109.130.26] by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NJW006VPOX97680@eusync3.samsung.com>; Tue, 17 Feb 2015 08:00:54 +0000 (GMT) Message-id: <54E2F52D.3060007@partner.samsung.com> Date: Tue, 17 Feb 2015 08:01:00 -0000 From: Maxim Ostapenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Cc: Slava Garbuzov , Yury Gribov Subject: Re: [PATCH][PR gdb/17984] Fix GDB build fail on Aarch64 when -fno-common is enabled. References: <54E219D5.1080702@partner.samsung.com> <54E27412.8010406@redhat.com> In-reply-to: <54E27412.8010406@redhat.com> Content-type: multipart/mixed; boundary=------------020407000606090402030104 X-SW-Source: 2015-02/txt/msg00408.txt.bz2 This is a multi-part message in MIME format. --------------020407000606090402030104 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-length: 148 Pedro, thanks for review. I'm sorry, but I'm unable to commit the patch, I have no write access to GDB. Could you commit this one for me? -Maxim --------------020407000606090402030104 Content-Type: text/x-patch; name="Fix-GDB-build-fail-on-Aarch64-when-fno-common-is-ena.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="Fix-GDB-build-fail-on-Aarch64-when-fno-common-is-ena.diff" Content-length: 1682 Fix GDB build fail on Aarch64 when -fno-common is enabled. gdb/ PR gdb/17984 * aarch64-linux-nat.c: Don't include features/aarch64.c anymore. (aarch64_linux_read_description): Remove initialize_tdesc_aarch64 call. * aarch64-tdep.h: Add struct target_desc *tdesc_aarch64 declaration. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0bd0792..d2352c9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2015-02-17 Max Ostapenko + + PR gdb/17984 + * aarch64-linux-nat.c: Don't include features/aarch64.c anymore. + (aarch64_linux_read_description): Remove initialize_tdesc_aarch64 call. + * aarch64-tdep.h: Add struct target_desc *tdesc_aarch64 + declaration. + 2015-02-13 Doug Evans * cp-namespace.c (cp_basic_lookup_symbol): Rename parameter diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c index c58f68a..aae4853 100644 --- a/gdb/aarch64-linux-nat.c +++ b/gdb/aarch64-linux-nat.c @@ -37,8 +37,6 @@ #include "gregset.h" -#include "features/aarch64.c" - /* Defines ps_err_e, struct ps_prochandle. */ #include "gdb_proc_service.h" @@ -830,7 +828,6 @@ aarch64_linux_child_post_startup_inferior (struct target_ops *self, static const struct target_desc * aarch64_linux_read_description (struct target_ops *ops) { - initialize_tdesc_aarch64 (); return tdesc_aarch64; } diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h index 6a7794d..976ad32 100644 --- a/gdb/aarch64-tdep.h +++ b/gdb/aarch64-tdep.h @@ -90,4 +90,6 @@ struct gdbarch_tdep struct type *vnb_type; }; +extern struct target_desc *tdesc_aarch64; + #endif /* aarch64-tdep.h */ -- 1.8.5.2.2930.gf745acb --------------020407000606090402030104--