From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18805 invoked by alias); 16 Feb 2015 22:56:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18793 invoked by uid 89); 16 Feb 2015 22:56:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 16 Feb 2015 22:56:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1GMtuNe006162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Feb 2015 17:56:00 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1GMtsmD021948; Mon, 16 Feb 2015 17:55:55 -0500 Message-ID: <54E2757A.2020808@redhat.com> Date: Mon, 16 Feb 2015 22:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: John Baldwin CC: gdb-patches@sourceware.org, Mark Kettenis Subject: Re: [PATCH] Fix signal trampoline detection/unwinding on recent FreeBSD/i386 and FreeBSD/amd64 References: <11386216.Yv1qECs4Mc@ralph.baldwin.cx> <1764587.lQfaPVNLAm@ralph.baldwin.cx> <54DB85F1.3070901@redhat.com> <5792555.u7sbdTrmvU@ralph.baldwin.cx> In-Reply-To: <5792555.u7sbdTrmvU@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00370.txt.bz2 On 02/16/2015 04:37 PM, John Baldwin wrote: > On Wednesday, February 11, 2015 04:40:17 PM Pedro Alves wrote: >> On 02/11/2015 03:32 PM, John Baldwin wrote: >>> Actually, this does sound far simpler. I was simply updating the sigtramp >>> code that was already present. I can certainly work on changing both i386 >>> and amd64 to do this instead if that is the preferred method (and it seems >>> to be from looking at other targets). >> >> Yep, that's the preferred method. That'd be great. > > I've implemented this and attached the updated patch below. I'm not quite > sure if the updated Changelog is correct however. I ran into one hiccup > though which is that the signal trampoline code is not included in process > core dumps in recent FreeBSD versions (after it was moved off of the stack and > into a global shared page). I've fixed this in FreeBSD so that future > versions will include the trampoline in core dumps, but I've retained the > change to use KERN_PROC_SIGTRAMP to support core dumps from the versions that > do not include it in the core. I've removed the support for specifying a > signal trampoline location for older verions using either hardcoded offsets or > ps_strings as it is no longer needed. Looks great to me! Mark, any comments? (I see a couple minor formatting issues, but I can fix them up for you before pushing.) Thanks, Pedro Alves