From: Pedro Alves <palves@redhat.com>
To: Maxim Ostapenko <m.ostapenko@partner.samsung.com>,
gdb-patches@sourceware.org
Cc: Slava Garbuzov <v.garbuzov@samsung.com>,
Yury Gribov <y.gribov@samsung.com>
Subject: Re: [PATCH][PR gdb/17984] Fix GDB build fail on Aarch64 when -fno-common is enabled.
Date: Mon, 16 Feb 2015 22:50:00 -0000 [thread overview]
Message-ID: <54E27412.8010406@redhat.com> (raw)
In-Reply-To: <54E219D5.1080702@partner.samsung.com>
On 02/16/2015 04:24 PM, Maxim Ostapenko wrote:
> current trunk GDB (and gdb-7.8.1 too) fails to build on Aarch64 when
> -fno-common is enabled with:
> This small patch resolves the issue, OK to commit?
Thanks.
> gdb/Changelog
>
> 2015-02-16 Max Ostapenko <m.ostapenko@partner.samsung.com>
>
> PR gdb/17984
> * gdb/aarch64-linux-nat.c: Don't include features/aarch64.c anymore.
> (aarch64_linux_read_description): Remove initialize_tdesc_aarch64 call.
> * gdb/aarch64-tdep.h: Add struct target_desc *tdesc_aarch64
> declaration.
As this entry will be added to the gdb/ChangeLog file, the
"gdb/" path should be removed from the file names above.
Otherwise this is OK. Thanks for doing this.
--
Pedro Alves
next prev parent reply other threads:[~2015-02-16 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 17:25 Maxim Ostapenko
2015-02-16 22:50 ` Pedro Alves [this message]
2015-02-17 8:01 ` Maxim Ostapenko
2015-02-17 9:46 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E27412.8010406@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=m.ostapenko@partner.samsung.com \
--cc=v.garbuzov@samsung.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox