Re: [PATCH][PR gdb/17984] Fix GDB build fail on Aarch64 when -fno-common is enabled.

Maxim Ostapenko
2015-02-17T08:01:00Z

[-- Attachment #1: Type: text/plain, Size: 148 bytes --]

Pedro,

thanks for review. I'm sorry, but I'm unable to commit the patch, I have
no write access to GDB. Could you commit this one for me?

-Maxim

[-- Attachment #2: Fix-GDB-build-fail-on-Aarch64-when-fno-common-is-ena.diff --]
[-- Type: text/x-patch, Size: 1682 bytes --]

Fix GDB build fail on Aarch64 when -fno-common is enabled.

gdb/

PR gdb/17984
* aarch64-linux-nat.c: Don't include features/aarch64.c anymore.
(aarch64_linux_read_description): Remove initialize_tdesc_aarch64 call.
* aarch64-tdep.h: Add struct target_desc *tdesc_aarch64
declaration.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0bd0792..d2352c9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2015-02-17 Max Ostapenko <m.ostapenko@partner.samsung.com>
+
+ PR gdb/17984
+ * aarch64-linux-nat.c: Don't include features/aarch64.c anymore.
+ (aarch64_linux_read_description): Remove initialize_tdesc_aarch64 call.
+ * aarch64-tdep.h: Add struct target_desc *tdesc_aarch64
+ declaration.
+
2015-02-13 Doug Evans <dje@google.com>

* cp-namespace.c (cp_basic_lookup_symbol): Rename parameter
diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c
index c58f68a..aae4853 100644
--- a/gdb/aarch64-linux-nat.c
+++ b/gdb/aarch64-linux-nat.c
@@ -37,8 +37,6 @@

#include "gregset.h"

-#include "features/aarch64.c"
-
/* Defines ps_err_e, struct ps_prochandle. */
#include "gdb_proc_service.h"

@@ -830,7 +828,6 @@ aarch64_linux_child_post_startup_inferior (struct target_ops *self,
static const struct target_desc *
aarch64_linux_read_description (struct target_ops *ops)
{
- initialize_tdesc_aarch64 ();
return tdesc_aarch64;
}

diff --git a/gdb/aarch64-tdep.h b/gdb/aarch64-tdep.h
index 6a7794d..976ad32 100644
--- a/gdb/aarch64-tdep.h
+++ b/gdb/aarch64-tdep.h
@@ -90,4 +90,6 @@ struct gdbarch_tdep
struct type *vnb_type;
};

+extern struct target_desc *tdesc_aarch64;
+
#endif /* aarch64-tdep.h */
--
1.8.5.2.2930.gf745acb