From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22369 invoked by alias); 14 Feb 2015 18:36:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22297 invoked by uid 89); 14 Feb 2015 18:36:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 14 Feb 2015 18:36:36 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1EIaVbP028288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 14 Feb 2015 13:36:31 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1EIaTPt007468; Sat, 14 Feb 2015 13:36:29 -0500 Message-ID: <54DF95AC.2090707@redhat.com> Date: Sat, 14 Feb 2015 18:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Doug Evans CC: Andrew Pinski , "gdb-patches@sourceware.org" , GCC Patches Subject: Re: [PATCH 09/36] floatformat.h: Wrap in extern "C". References: <1423524046-20605-1-git-send-email-palves@redhat.com> <1423524046-20605-10-git-send-email-palves@redhat.com> <54D94780.9050606@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00353.txt.bz2 On 02/14/2015 05:29 PM, Doug Evans wrote: > On Mon, Feb 9, 2015 at 3:49 PM, Pedro Alves wrote: >> On 02/09/2015 11:35 PM, Andrew Pinski wrote: >>> Why is not needed for GCC building with C++ compiler? >> >> Because it doesn't include it. >> >> The header of the file claims it is part of GDB, though MAINTAINERS >> nowadays says that everything under include/ is owned by GCC. > > Wait, what? > > The actual wording is: > "The rule is that if the file exists in the gcc tree then gcc owns it." I was paraphrasing, and simplified it. That distinction seems irrelevant to me here because the file does exist in the gcc tree. It's necessary to build libiberty (for libiberty/floatformat.o). It's a fact that the header claims it is part of GDB: ~~~~~~ /* IEEE floating point support declarations, for GDB, the GNU Debugger. Copyright (C) 1991-2015 Free Software Foundation, Inc. This file is part of GDB. (...) ~~~~~~ I guess it should say that it is part of libiberty instead. > It originated from this thread, > https://sourceware.org/ml/gdb/2013-11/msg00025.html > That's not the first message in the thread, but that's where > I remember wanting to see something written down. > > Perhaps kinda unfortunate for things like include/gdb/gdb-index.h. > But at least it's a rule that can be expressed in one sentence, > and I don't think it's been a problem. I'm confused -- I didn't say it was a problem, nor expressed any concern with the rule. I just was pointing out facts. ISTM that the procedure here is to push this change first through the gcc repo first, and then merge it to binutils-gdb git. Is that wrong? Thanks, Pedro Alves