From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32736 invoked by alias); 12 Feb 2015 20:38:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32709 invoked by uid 89); 12 Feb 2015 20:38:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 12 Feb 2015 20:38:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CKcNp5002449 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 12 Feb 2015 15:38:24 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CKcMic012982; Thu, 12 Feb 2015 15:38:22 -0500 Message-ID: <54DD0F3D.6010809@redhat.com> Date: Thu, 12 Feb 2015 20:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches Subject: Re: [PATCH] Merge dg-extract-results.{sh,py} from GCC upstream References: <1418686405-29922-1-git-send-email-sergiodj@redhat.com> <54DD0C8F.6050303@redhat.com> <87zj8idg6r.fsf@redhat.com> In-Reply-To: <87zj8idg6r.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00335.txt.bz2 On 02/12/2015 08:32 PM, Sergio Durigan Junior wrote: > On Thursday, February 12 2015, Pedro Alves wrote: > >>> gdb/testsuite/ChangeLog: >>> 2014-12-14 Sergio Durigan Junior >>> >>> Merge dg-extract-results.{sh,py} from GCC upstream (r210243, >>> r210637, r210913, r211666, r215400, r215817). >>> >>> 2014-05-08 Richard Sandiford >>> * dg-extract-results.py: New file. >> >> Unfortunately, the Python version of this script (dg-extract-results.py) >> doesn't produce stable results. The sorting changes between runs for >> some reason. That may be tolerable for GCC, but for GDB, it often >> renders test diffing unworkable. > > Sorry for not catching this before. > > Our BuildBot does not suffer from this because it doesn't rely on the > order of the results in the .sum file... > >> I think we should remove dg-extract-results.py, and re-sync >> dg-extract-results.sh from the gcc repo to pick up your fix for >> the grep/binary issue that went in meanwhile. >> >> WDYT? > > I'm in favor. But just to be safe (sorry for repeating): we need to > pick up my fix from GCC. Otherwise the BuildBot wil be badly affected. Wait, we may have gotten things backwards. Aren't we using the .sh version still? testsuite/Makefile.in: check-parallel: -rm -rf cache outputs temp $(MAKE) -k do-check-parallel; \ $(SHELL) $(srcdir)/dg-extract-results.sh \ `find outputs -name gdb.sum -print` > gdb.sum; \ $(SHELL) $(srcdir)/dg-extract-results.sh -L \ `find outputs -name gdb.log -print` > gdb.log @sed -n '/=== gdb Summary ===/,$$ p' gdb.sum Now I'm confused. Is the issue then that patches to the .sh version that we pulled in with the last merge introduced the bad sorting? /me confused. Thanks, Pedro Alves