From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31759 invoked by alias); 12 Feb 2015 14:43:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31750 invoked by uid 89); 12 Feb 2015 14:43:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 12 Feb 2015 14:43:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CEh9h8008386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 Feb 2015 09:43:09 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CEh7VF009267; Thu, 12 Feb 2015 09:43:08 -0500 Message-ID: <54DCBBFB.4020506@redhat.com> Date: Thu, 12 Feb 2015 14:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH 03/36] C++ keyword cleanliness, mostly auto-generated References: <1423524046-20605-1-git-send-email-palves@redhat.com> <1423524046-20605-4-git-send-email-palves@redhat.com> <20150211075749.GJ4738@adacore.com> <54DB2E8D.9000103@redhat.com> <54DB3416.1010404@redhat.com> <20150212121910.GL4738@adacore.com> <54DCA74C.3000208@redhat.com> In-Reply-To: <54DCA74C.3000208@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00323.txt.bz2 On 02/12/2015 01:14 PM, Pedro Alves wrote: >> > I haven't had a chance to review all the patches, and I will admit >> > that I winced a little when seeing some of them (but accepted them), > Not sure whether I want to ask which. :-) Probably a minor thing, but I'd like to avoid a potential misunderstanding here. I just realized that I never really knew what "winced" really means, and that I may have misinterpreted what you said, which I guess can make my response sound odd. What I understood was that some of the patches were ugly, but you accepted them anyway in the name of progress. :-) Thanks, Pedro Alves