From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21496 invoked by alias); 12 Feb 2015 11:34:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21473 invoked by uid 89); 12 Feb 2015 11:34:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 12 Feb 2015 11:34:08 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1CBY4as014826 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 12 Feb 2015 06:34:05 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1CBY3HS023096; Thu, 12 Feb 2015 06:34:04 -0500 Message-ID: <54DC8FAB.9040004@redhat.com> Date: Thu, 12 Feb 2015 11:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 00/36] Support building GDB as a C++ program References: <1423524046-20605-1-git-send-email-palves@redhat.com> <54DB8E32.7040109@gmail.com> In-Reply-To: <54DB8E32.7040109@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00319.txt.bz2 On 02/11/2015 05:15 PM, Yao Qi wrote: > Hi Pedro, > Nice to see these patches for c++ conversion, and thanks very much > for doing this. I went through the first 30 patches, and skimmed > the rest today. Don't see anything wrong obviously. Awesome! Thanks for reading. >> See the project page here:https://sourceware.org/gdb/wiki/cxx-conversion >> >> This series implements the first parts of the transition plan >> described in that page. Namely: >> >> - Add a --enable-build-with-cxx option (default: no) to compile GDB >> and GDBserver with a C++ compiler, keeping the support for >> building with a C compiler. >> >> - Modify GDB and GDBserver so they can be compiled in C++ mode, >> using G++'s '-fpermissive' option as shortcut. >> >> - Split the TRY_CATCH macro into TRY/CATCH macros to better map to >> C++'s 'throw'/'try...catch' in C++ mode, and eliminate all the >> volatile gdb_exception objects. > > To be clear, according to the transition plan on wiki, once this patch > set is pushed in, we'll be at step 8.1, except that step 6 is not > needed, and step 1 and 5 are skipped. Is it a correct understanding? I've now added pointers this thread, and to git branches, to the transition plan in the wiki. I'd rather say we've done up to 4, and done 8.1. Not sure if we do need to do anything special for step 1, other than just keeping it in mind during reviews. Step 5 still needs doing before we can consider flipping the default to be C++ mode. As for the patch for 8.1, as is, we'll be throwing C++ exception from signal handlers. I think we'll need to change GDB not to do that before we can require a C++ compiler. See also: https://sourceware.org/ml/gdb-patches/2015-02/msg00272.html I haven't done anything on that front. Help would be very much appreciated. Thanks, Pedro Alves