Re: [PATCH 03/36] C++ keyword cleanliness, mostly auto-generated

Phil Muldoon
2015-02-11T08:52:51Z

On 11/02/15 07:57, Joel Brobecker wrote:
> On Mon, Feb 09, 2015 at 11:20:13PM +0000, Pedro Alves wrote:
>> This patch renames symbols that happen to have names which are
>> reserved keywords in C++.
>>
>> Most of this was generated with Tromey's cxx-conversion.el script.
>> Some places where later hand massaged a bit, to fix formatting, etc.
>> And this was rebased several times meanwhile, along with re-running
>> the script, so re-running the script from scratch probably does not
>> result in the exact same output. I don't think that matters anyway.
>>
>> gdb/
>> 2015-02-09 Tom Tromey <tromey@redhat.com>
>> Pedro Alves <palves@redhat.com>
>>
>> Rename symbols whose names are reserved C++ keywords throughout.
>
> *if* this is reasonably easy to do, can we rename "namespace" into
> "domain" instead of "the_namespace"? "namespace" comes from our old
> terminology, I think, and we've been using "enum_domain" since, so
> if we're going to have to change the variable/parameter names also,
> might as well use "domain" instead?

I agree, I think this would be a good idea. "domain" makes more
sense. Same caveats apply as Joel stated; I'll happily accept
"the_namespace" if "domain" delays the patch-set overly.

Cheers

Phil