Re: [PATCH 00/36] Support building GDB as a C++ program

Pedro Alves
2015-02-12T11:34:10Z

On 02/11/2015 05:15 PM, Yao Qi wrote:
> Hi Pedro,
> Nice to see these patches for c++ conversion, and thanks very much
> for doing this. I went through the first 30 patches, and skimmed
> the rest today. Don't see anything wrong obviously.

Awesome! Thanks for reading.

>> See the project page here:https://sourceware.org/gdb/wiki/cxx-conversion
>>
>> This series implements the first parts of the transition plan
>> described in that page. Namely:
>>
>> - Add a --enable-build-with-cxx option (default: no) to compile GDB
>> and GDBserver with a C++ compiler, keeping the support for
>> building with a C compiler.
>>
>> - Modify GDB and GDBserver so they can be compiled in C++ mode,
>> using G++'s '-fpermissive' option as shortcut.
>>
>> - Split the TRY_CATCH macro into TRY/CATCH macros to better map to
>> C++'s 'throw'/'try...catch' in C++ mode, and eliminate all the
>> volatile gdb_exception objects.
>
> To be clear, according to the transition plan on wiki, once this patch
> set is pushed in, we'll be at step 8.1, except that step 6 is not
> needed, and step 1 and 5 are skipped. Is it a correct understanding?

I've now added pointers this thread, and to git branches, to the
transition plan in the wiki.

I'd rather say we've done up to 4, and done 8.1. Not sure if we do need
to do anything special for step 1, other than just keeping it in mind
during reviews. Step 5 still needs doing before we can consider flipping
the default to be C++ mode.

As for the patch for 8.1, as is, we'll be throwing C++ exception from
signal handlers. I think we'll need to change GDB not to do that
before we can require a C++ compiler. See also:

https://sourceware.org/ml/gdb-patches/2015-02/msg00272.html

I haven't done anything on that front. Help would be very much appreciated.

Thanks,
Pedro Alves