From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18675 invoked by alias); 11 Feb 2015 08:52:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18644 invoked by uid 89); 11 Feb 2015 08:52:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 11 Feb 2015 08:52:50 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1B8qlav002791 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 11 Feb 2015 03:52:47 -0500 Received: from localhost.localdomain (ovpn-112-26.ams2.redhat.com [10.36.112.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1B8qjXG026260; Wed, 11 Feb 2015 03:52:46 -0500 Message-ID: <54DB185C.1020209@redhat.com> Date: Wed, 11 Feb 2015 08:52:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Joel Brobecker , Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [PATCH 03/36] C++ keyword cleanliness, mostly auto-generated References: <1423524046-20605-1-git-send-email-palves@redhat.com> <1423524046-20605-4-git-send-email-palves@redhat.com> <20150211075749.GJ4738@adacore.com> In-Reply-To: <20150211075749.GJ4738@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00294.txt.bz2 On 11/02/15 07:57, Joel Brobecker wrote: > On Mon, Feb 09, 2015 at 11:20:13PM +0000, Pedro Alves wrote: >> This patch renames symbols that happen to have names which are >> reserved keywords in C++. >> >> Most of this was generated with Tromey's cxx-conversion.el script. >> Some places where later hand massaged a bit, to fix formatting, etc. >> And this was rebased several times meanwhile, along with re-running >> the script, so re-running the script from scratch probably does not >> result in the exact same output. I don't think that matters anyway. >> >> gdb/ >> 2015-02-09 Tom Tromey >> Pedro Alves >> >> Rename symbols whose names are reserved C++ keywords throughout. > > *if* this is reasonably easy to do, can we rename "namespace" into > "domain" instead of "the_namespace"? "namespace" comes from our old > terminology, I think, and we've been using "enum_domain" since, so > if we're going to have to change the variable/parameter names also, > might as well use "domain" instead? I agree, I think this would be a good idea. "domain" makes more sense. Same caveats apply as Joel stated; I'll happily accept "the_namespace" if "domain" delays the patch-set overly. Cheers Phil