From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11403 invoked by alias); 10 Feb 2015 17:30:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11340 invoked by uid 89); 10 Feb 2015 17:30:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 10 Feb 2015 17:30:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1AHTw34021694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Feb 2015 12:29:58 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1AHTufg014508; Tue, 10 Feb 2015 12:29:57 -0500 Message-ID: <54DA4014.4010602@redhat.com> Date: Tue, 10 Feb 2015 17:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix truncation of TUI command history References: <1420861759-10700-1-git-send-email-patrick@parcs.ath.cx> <1420861759-10700-2-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1420861759-10700-2-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00268.txt.bz2 On 01/10/2015 03:49 AM, Patrick Palka wrote: > We need to move the cursor because > when ncurses outputs a newline it truncates any text that appears > past the end of the cursor. Can you merge this sentence into the comment in the code? > else > { > - wmove (w, TUI_CMD_WIN->detail.command_info.cur_line, > - TUI_CMD_WIN->detail.command_info.curch); > - waddch (w, ch); > + /* Move cursor to the end of the command line before emitting the > + newline. */ ... as this as is doesn't explain _why_ we need to do that, which may make the reader wonder. > + int px = TUI_CMD_WIN->detail.command_info.curch; > + int py = TUI_CMD_WIN->detail.command_info.cur_line; > + px += rl_end - rl_point; > + py += px / TUI_CMD_WIN->generic.width; > + px %= TUI_CMD_WIN->generic.width; > + wmove (w, py, px); > + waddch (w, ch); > } > } > > OK with that change. Thanks! Thanks, Pedro Alves