From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5527 invoked by alias); 10 Feb 2015 16:39:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5512 invoked by uid 89); 10 Feb 2015 16:39:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 10 Feb 2015 16:39:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1AGdJcU030257 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Feb 2015 11:39:19 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1AGdH0r014741; Tue, 10 Feb 2015 11:39:18 -0500 Message-ID: <54DA3435.6090304@redhat.com> Date: Tue, 10 Feb 2015 16:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH v4 6/7] Remote follow vfork References: <54C236B9.8060200@redhat.com> <1422222420-25421-1-git-send-email-donb@codesourcery.com> <1422222420-25421-7-git-send-email-donb@codesourcery.com> In-Reply-To: <1422222420-25421-7-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00263.txt.bz2 Hi Don, No major comments here, other than what's been said in previous patches. A couple remarks only. On 01/25/2015 09:46 PM, Don Breazeal wrote: > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -1481,7 +1481,10 @@ remote_follow_fork (struct target_ops *target, int follow_child, > pid_t child_pid; > > gdb_assert ((inferior_thread ()->pending_follow.kind > - == TARGET_WAITKIND_FORKED)); > + == TARGET_WAITKIND_FORKED) > + || (inferior_thread ()->pending_follow.kind > + == TARGET_WAITKIND_VFORKED)); > + Please use a temporary variable, something like: kind = inferior_thread ()->pending_follow.kind gdb_assert (kind == TARGET_WAITKIND_FORKED) || (kind == TARGET_WAITKIND_VFORKED)); Makes it easier to debug a core dump caused by this assert. > child_ptid = inferior_thread ()->pending_follow.value.related_pid; > child_pid = ptid_get_pid (child_ptid); > > @@ -4502,7 +4505,8 @@ remote_detach_1 (struct target_ops *ops, const char *args, > { > inferior_ptid = null_ptid; > detach_inferior (pid); > - inf_child_maybe_unpush_target (ops); > + if (!extended) > + inf_child_maybe_unpush_target (ops); Hmm, I'm afraid I don't understand why is this part of this patch? Thanks, Pedro Alves