From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16673 invoked by alias); 9 Feb 2015 01:48:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16514 invoked by uid 89); 9 Feb 2015 01:48:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-177.mail.aliyun.com Received: from out1134-177.mail.aliyun.com (HELO out1134-177.mail.aliyun.com) (42.120.134.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Feb 2015 01:48:23 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.0777218|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r46d02012;MF=gang.chen@sunrus.com.cn;PH=DS;RN=3;RT=3;SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:124.127.118.42) by smtp.aliyun-inc.com(10.194.100.39); Mon, 09 Feb 2015 09:48:12 +0800 Message-ID: <54D813B0.5060809@sunrus.com.cn> Date: Mon, 09 Feb 2015 01:48:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Joel Brobecker CC: Doug Evans , "gdb-patches@sourceware.org" Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings. References: <54D61EFC.3040000@sunrus.com.cn> <54D6A794.7080107@sunrus.com.cn> <54D6BE70.2080708@sunrus.com.cn> <20150208160010.GE4738@adacore.com> In-Reply-To: <20150208160010.GE4738@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00186.txt.bz2 On 2/9/15 00:00, Joel Brobecker wrote: >>>>>> 2015-02-07 Chen Gang >>>>>> >>>>>> * mcore/interp.c: Include "unistd.h" standard C header file to >>>>>> avoid compiling warnings. > > A couple of small procedural nits... > > There is a ChangeLog file in sim/mcore, so this is the one that > should be updated, and thus the name of the file in the ChangeLog > entry should not have the "mcore/" part. > > Also, the ChangeLog entry should only say "what" has been changed, > not "why". If you feel that the "why" needs to be provided, it should > be provided in the code. In this case, I feel that your revision log > is sufficient. > > So, your ChangeLog entry should look like: > > 2015-02-07 Chen Gang > > * interp.c: Include "unistd.h". OK, thanks. I guess, before "git push", I need send patch v2 to mailing list. If no any additional reply, I shall send patch v2 within 2015-02-10. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed