Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: <lgustavo@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdbserver: Fix crash when QTinit is handled with no inferior process attached
Date: Thu, 05 Feb 2015 14:06:00 -0000	[thread overview]
Message-ID: <54D378FA.1090809@ericsson.com> (raw)
In-Reply-To: <54D3787A.60605@codesourcery.com>


On 02/05/2015 09:04 AM, Luis Machado wrote:
> On 02/05/2015 11:53 AM, Antoine Tremblay wrote:
>> Hi,
>>     I'm quite new to gdb, but in general I would argue that it's better
>> to make a program resilient to wrong input then to sanitize the input,
>> let's say someday something else then gdb would use gdbserver....?
>
> It is certainly a valid concern.
>
>>
>>     But I sure would like to take a look at your patch if you have it
>> handy ?
>
> I just need to extract it from the tree and do a bit of an update. We 
> could probably merge both to robustify the tracepoint mechanism.
>
Yes that's sounds a good idea :)

Thanks!

>> On 02/05/2015 08:44 AM, Luis Machado wrote:
>>> On 02/05/2015 11:37 AM, Luis Machado wrote:
>>>> On 02/05/2015 11:30 AM, Antoine Tremblay wrote:
>>>>> ping
>>>>>
>>>>> On 01/27/2015 02:35 PM, Antoine Tremblay wrote:
>>>>>> When gdbserver is called with --multi and attach has not been
>>>>>> called yet
>>>>>> and tstart is called on the gdb client, gdbserver would crash.
>>>>>> This patch fixes gdbserver so that it returns E01 to the gdb client.
>>>>
>>>> Wouldn't it make more sense to prevent GDB from sending any tracepoint
>>>> packets that require a running inferior if there is none?
>>>>
>>>> I remember fixing this in a local tree but on GDB's side. I think 
>>>> it is
>>>> remote.c:remote_trace_init and other related functions.
>>>>
>>>> What do you think?
>>>
>>> I've looked around and found the patch in a local tree of mine. It
>>> fixes more cases of tracepoint commands that require a running 
>>> inferior.
>>>
>>> I could revive and submit it if it makes things easier.
>>>
>>
>


  reply	other threads:[~2015-02-05 14:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 11:37 Antoine Tremblay
2015-02-05 13:30 ` Antoine Tremblay
2015-02-05 13:37   ` Luis Machado
2015-02-05 13:44     ` Luis Machado
2015-02-05 13:53       ` Antoine Tremblay
2015-02-05 14:04         ` Luis Machado
2015-02-05 14:06           ` Antoine Tremblay [this message]
2015-02-05 17:36             ` Pedro Alves
2015-02-05 20:06               ` [PATCH v2] " Antoine Tremblay
2015-02-06 15:50                 ` Pedro Alves
2015-02-06 16:25                   ` [PATCH v3] " Antoine Tremblay
2015-02-06 17:11                     ` Pedro Alves
2015-02-06 17:36                       ` Antoine Tremblay
2015-02-10 16:46                         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D378FA.1090809@ericsson.com \
    --to=antoine.tremblay@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox