From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1019 invoked by alias); 5 Feb 2015 09:47:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 999 invoked by uid 89); 5 Feb 2015 09:47:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 05 Feb 2015 09:47:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t159lpq9005552 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 5 Feb 2015 04:47:51 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t159lnNT021755; Thu, 5 Feb 2015 04:47:50 -0500 Message-ID: <54D33C45.4010706@redhat.com> Date: Thu, 05 Feb 2015 09:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org CC: Andreas Arnez Subject: Re: ping: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big References: <874ms18cyz.fsf@br87z6lw.de.ibm.com> <20150108164327.GA29029@host2.jankratochvil.net> <20150205073758.GA25305@host1.jankratochvil.net> In-Reply-To: <20150205073758.GA25305@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00119.txt.bz2 On 02/05/2015 08:37 AM, Jan Kratochvil wrote: > Hi, > Thanks for the test case. > now when the fix is checked-in even the testcase could be. > > OK for check-in? It's not obvious to me why is the file uuencoded. What's the reason for that? I can think of a reason, but I don't want to guess. > +# Wrongly built GDB complains by: > +# "..." is not a core dump: File format not recognized > +# As the provided test core has 64bit PRSTATUS i386 built GDB cannot parse it. > +# This is just a problem of the test care, real-world elf64-i386 file will have > +# 32bit PRSTATUS. One cannot prepare elf64-i386 core file from elf32-i386 by > +# objcopy as it corrupts the core file beyond all recognition. > +# "\r\nCore was generated by `\[^\r\n\]*'\\.\r\nProgram terminated with signal 11, Segmentation fault\\.\r\n.*" Hmm, this line is commented out, but there's no explanation of why that is. Is that a left over that was intended to be used in the gdb_test below? As is, it seems like the gdb_test below will PASS even on buggy GDB? > +gdb_test "core-file ${corefile}" ".*" "core-file" > + > +gdb_test "x/i $address" "\r\n\[ \t\]*$address:\[ \t\]*hlt\[ \t\]*" ".text is readable" Thanks, Pedro Alves