Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix Python 3 build error on 32-bit hosts
Date: Wed, 04 Feb 2015 18:58:00 -0000	[thread overview]
Message-ID: <54D26BCA.2000505@redhat.com> (raw)
In-Reply-To: <20150204174311.GA24375@host1.jankratochvil.net>

On 02/04/2015 06:43 PM, Jan Kratochvil wrote:

> A question is whether the autoconf test isn't an overkill.  

I agree with Paul here.  I think checking Python version is sufficient.

One could use
> instead just:
> 	#if PYTHON_ABI_VERSION >= 3

This

  https://docs.python.org/3/c-api/object.html#PyObject_Hash

and a quick web search for Py_hash_t seems to indicate that we should
check for Python >=3.2, not just 3.

> Also one could use that #if either just at the valpy_hash() definition or one
> could provide Py_hash_t in gdb/defs.h or one could provide some GDB_Py_hash_t
> in gdb/defs.h.

I'd be fine with providing a fallback Py_hash_t in python/python-internal.h,
where we already do a series of fallback definitions and fixes for older
Python, such as e.g. Py_ssize_t.

Thanks,
Pedro Alves


  parent reply	other threads:[~2015-02-04 18:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 17:43 Jan Kratochvil
2015-02-04 18:39 ` Paul_Koning
2015-02-04 18:58 ` Pedro Alves [this message]
2015-02-04 19:08   ` Pedro Alves
2015-02-04 19:20   ` [patchv2] " Jan Kratochvil
2015-02-04 19:27     ` Pedro Alves
2015-02-04 19:34       ` [commit] " Jan Kratochvil
2015-02-04 19:42         ` Pedro Alves
2015-02-04 19:51         ` Phil Muldoon
2015-02-04 21:06     ` Paul_Koning

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D26BCA.2000505@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox