From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21189 invoked by alias); 30 Jan 2015 20:16:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21144 invoked by uid 89); 30 Jan 2015 20:15:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 30 Jan 2015 20:15:56 +0000 Received: from EUSAAHC007.ericsson.se (Unknown_Domain [147.117.188.93]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 3B.1B.03307.5739BC45; Fri, 30 Jan 2015 15:21:41 +0100 (CET) Received: from [142.133.110.232] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.95) with Microsoft SMTP Server id 14.3.195.1; Fri, 30 Jan 2015 15:15:53 -0500 Message-ID: <54CBE679.3020209@ericsson.com> Date: Sat, 31 Jan 2015 01:14:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH 5/6] Mention that create_child takes ownership of the allocated name References: <1422559716-5480-1-git-send-email-simon.marchi@ericsson.com> <1422559716-5480-5-git-send-email-simon.marchi@ericsson.com> <20150130033545.GM5193@adacore.com> In-Reply-To: <20150130033545.GM5193@adacore.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00804.txt.bz2 On 15-01-29 10:35 PM, Joel Brobecker wrote: >> gdb/ChangeLog: >> >> * varobj.c (create_child): Modify comment. > > OK, with one favor if you wouldn't mind. > >> --- >> gdb/varobj.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/gdb/varobj.c b/gdb/varobj.c >> index 0daef91..d3fa1ba 100644 >> --- a/gdb/varobj.c >> +++ b/gdb/varobj.c >> @@ -2043,7 +2043,9 @@ uninstall_variable (struct varobj *var) >> >> } >> >> -/* Create and install a child of the parent of the given name. */ >> +/* Create and install a child of the parent of the given name. >> + >> + The created VAROBJ takes ownership of the allocated NAME. */ >> static struct varobj * > > GDB's Coding Style requires that we have an empty line between > function documentation and function definition. It was missing > here, and since you're touching this area, would you mind adding it? > > Thank you! Thanks, pushed with an extra empty line.