From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119467-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7369 invoked by alias); 30 Jan 2015 18:57:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 7146 invoked by uid 89); 30 Jan 2015 18:57:16 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: usevmg20.ericsson.net
Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 30 Jan 2015 18:57:14 +0000
Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84])	by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 92.96.03307.4018BC45; Fri, 30 Jan 2015 14:03:00 +0100 (CET)
Received: from [142.133.110.232] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.86) with Microsoft SMTP Server id 14.3.195.1; Fri, 30 Jan 2015 13:57:12 -0500
Message-ID: <54CBD407.5070901@ericsson.com>
Date: Fri, 30 Jan 2015 22:57:00 -0000
From: Simon Marchi <simon.marchi@ericsson.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Joel Brobecker <brobecker@adacore.com>
CC: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/6] Free results of varobj_get_expression
References: <1422559716-5480-1-git-send-email-simon.marchi@ericsson.com> <20150130031258.GJ5193@adacore.com>
In-Reply-To: <20150130031258.GJ5193@adacore.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00801.txt.bz2



On 15-01-29 10:12 PM, Joel Brobecker wrote:
> On Thu, Jan 29, 2015 at 02:28:31PM -0500, Simon Marchi wrote:
>> varobj_get_expression returns an allocated string, which must be freed
>> by the caller.
>>
>> gdb/ChangeLog:
>>
>> 	* mi-cmd-var.c (print_varobj): Free varobj_get_expression
>> 	result.
>> 	(mi_cmd_var_info_expression): Same.
>> 	* varobj.c (varobj_get_expression): Mention in the comment that
>> 	the result must by freed by the caller.
> 
> OK!
> 
> Thank you,

Pushed, thanks!