Re: [PATCH v2 13/13] [wip] btrace: support Intel(R) Processor Trace

Eli Zaretskii
2014-11-20T16:32:09Z

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org
> Date: Thu, 20 Nov 2014 11:47:24 +0100
>
> Adds a new command "record btrace pt" to configure the kernel to use
> Intel Processor Trace instead of Intel Branch Trace Strore.

Thanks.

> + warning (_("decode error near offset 0x%" PRIx64

Warning messages like this are sub-optimal, because they don't give
enough context to understand what happens. The user will likely
wonder what was GDB decoding when it hit that error.

> + error (_("Failed to configure trace decoder: %s."),
> + pt_errstr (pt_errcode (errcode)));

Likewise here: what "trace decoder" is being referred to?

I suggest to add text that provides the missing context, like "Failed
to configure trace decoder for Intel Process Trace."

> +If @var{size} is a positive number, then @value{GDBN} will try to
> +allocate a buffer of at least @var{size} bytes for each new thread
> +that uses the btrace recording method and the Intel Processor Trace
> +format. The actually obtained buffer size may differ from the
> +requested @var{size}. Use the @code{info record} command to see the
^^
Two spaces here.

The documentation parts are OK with that fixed.