From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5776 invoked by alias); 23 Jan 2015 10:59:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5549 invoked by uid 89); 23 Jan 2015 10:59:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 23 Jan 2015 10:58:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0NAwmU3027187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 23 Jan 2015 05:58:49 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0NAwlVr004167; Fri, 23 Jan 2015 05:58:47 -0500 Message-ID: <54C22966.8030603@redhat.com> Date: Fri, 23 Jan 2015 12:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Pierre Muller CC: "'gdb-patches'" Subject: Re: [RFA PATCH 3/3 V3] Testcase for pascal/17815 References: <54ae4586.01e3440a.7b06.fffff844SMTPIN_ADDED_BROKEN@mx.google.com> <54AE605A.8050308@redhat.com> <54ae7f9f.c323460a.36ed.ffffff30SMTPIN_ADDED_BROKEN@mx.google.com> <54AE8914.4010507@redhat.com> <54ae911b.85e3440a.1d96.5ffdSMTPIN_ADDED_BROKEN@mx.google.com> <54AFB2E5.5080307@redhat.com> <54afff6b.ee8d440a.16ee.ffffb424SMTPIN_ADDED_BROKEN@mx.google.com> <54C0F10E.60402@redhat.com> <002c01d036a2$7015e7b0$5041b710$@muller@ics-cnrs.unistra.fr> In-Reply-To: <002c01d036a2$7015e7b0$5041b710$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-01/txt/msg00644.txt.bz2 On 01/23/2015 12:20 AM, Pierre Muller wrote: > Hi Pedro, > >> -----Message d'origine----- >> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches- >> owner@sourceware.org] De la part de Pedro Alves >> Envoyé : jeudi 22 janvier 2015 13:46 >> À : Pierre Muller >> Cc : 'gdb-patches' >> Objet : Re: [RFA PATCH 3/3] Testcase for pascal/17815 >> >> Thanks for adding the test case. >> >> On 01/09/2015 04:18 PM, Pierre Muller wrote: >>> This adds the testcase for pascal/17815 bug report. >>> >>> >>> gdb/testsuite/Changelog entry: >>> >>> 2015-01-09 Pierre Muller >>> >>> gdb.pascal/gdb17815.pas: New file. >>> gdb.pascal/gdb17815.exp: New file. >> >> Missing '*'. > Fixed below. > >> Can you please pick a more descriptive name for the file? >> One that suggests what's being tested, rather than a bug >> number is ideal. E.g., gdb.pascal/case-insensitive.{exp|pas}. > > I used your suggestion, but this is not > really a general case insensitiveness test... You mean, it's just for symbols, rather than filesystems, etc? gdb.pascal/case-insensitive-symbols.{exp|pas} would be my suggestion then. But these are just suggestions. Feel free to pick something else. > > No, I tried and using runto_main, > I got only failures, because it apparently did not stop > at all on the breakpoint set earlier... > Is there some code inside runto_main that > deleted previously installed breakpoints? Yes, it's the first thing runto_main -> runto does. Why not just set the breakpoints after reaching main? Or simpler still, use "runto $foo" directly, like: set bp_location [gdb_get_line_number "set breakpoint here"] if { ![runto ${srcfile}:${bp_location}] } { return 0 } Or simpler still, just: if { ![runto "check"] } { return 0 } Assuming that to set a breakpoint on the "check" function, you'd do "break check" in GDB. If not, replace "check" with whatever linespec would be used instead. The patch looks good to me. Thanks, Pedro Alves