From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25914 invoked by alias); 22 Jan 2015 12:07:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25873 invoked by uid 89); 22 Jan 2015 12:07:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Jan 2015 12:07:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0MC7SYg027050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Jan 2015 07:07:28 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0MC7QRN026336; Thu, 22 Jan 2015 07:07:27 -0500 Message-ID: <54C0E7FE.4020401@redhat.com> Date: Thu, 22 Jan 2015 12:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCHSET] [4/4] Fix various issue in TUI References: <83vbkrbt4d.fsf@gnu.org> <54AAEC02.7020500@redhat.com> <83bnmd8028.fsf@gnu.org> <83y4p1zq7k.fsf@gnu.org> In-Reply-To: <83y4p1zq7k.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00586.txt.bz2 On 01/17/2015 09:55 AM, Eli Zaretskii wrote: >> > Date: Mon, 05 Jan 2015 22:06:07 +0200 >> > From: Eli Zaretskii >> > Cc: gdb-patches@sourceware.org >> > >>> > > Date: Mon, 05 Jan 2015 19:54:42 +0000 >>> > > From: Pedro Alves >>> > > >>> > > On 12/31/2014 05:56 PM, Eli Zaretskii wrote: >>>> > > > Well, one patch is Windows-specific after all. This patch makes sure >>>> > > > windows-termcap is not compiled when GDB is linked against ncurses, >>> > > >>> > > ... >>> > > >>>> > > > and also makes the file a no-op should it compile in that >>>> > > > configuration. >>> > > >>> > > With the configure.ac change, how can that happen? >> > >> > It shouldn't. I'd have preferred to drop that hunk then. It just seems to be either pointless or hiding some problem with the configure.ac check. > Don't use windows-termcap.c when linking against a curses library > > gdb/ > 2015-01-17 Eli Zaretskii > > * configure.ac [*mingw32*]: Only add windows-termcap.o to > CONFIG_OBS if not building with a curses library. > > * windows-termcap.c: Include defs.h. Make the whole body empty if > either one of HAVE_CURSES_H or HAVE_NCURSES_H or > HAVE_NCURSES_NCURSES_H is defined. > > diff --git a/gdb/configure.ac b/gdb/configure.ac > index 8dd7f8f..b852b93 100644 > --- a/gdb/configure.ac > +++ b/gdb/configure.ac > @@ -611,9 +611,10 @@ case $host_os in > ac_cv_search_tgetent="none required" > ;; > *mingw32*) > - ac_cv_search_tgetent="none required" > - CONFIG_OBS="$CONFIG_OBS windows-termcap.o" > - ;; > + if test x"$prefer_curses" != xyes; then > + ac_cv_search_tgetent="none required" > + CONFIG_OBS="$CONFIG_OBS windows-termcap.o" > + fi ;; I'm still confused and not convinced this is the right predicate. You said: "This patch makes sure windows-termcap is not compiled when GDB is linked against ncurses". But that doesn't look to be what the patch does. I asked about $curses_found before because AFAICS, it's quite possible for $prefer_curses to be set, but $curses_found to be "no". By default, we try configuring the TUI: # Enable TUI. AC_ARG_ENABLE(tui, AS_HELP_STRING([--enable-tui], [enable full-screen terminal user interface (TUI)]), [case $enableval in yes | no | auto) ;; *) AC_MSG_ERROR([bad value $enableval for --enable-tui]) ;; esac],enable_tui=auto) And that always results in $prefer_curses set to yes: # For the TUI, we need enhanced curses functionality. if test x"$enable_tui" != xno; then prefer_curses=yes fi But then we check if curses is really found: curses_found=no if test x"$prefer_curses" = xyes; then ... AC_SEARCH_LIBS(waddstr, [ncurses cursesX curses]) if test "$ac_cv_search_waddstr" != no; then curses_found=yes fi fi And then it's $curses_found that we check: # Check whether we should enable the TUI, but only do so if we really # can. if test x"$enable_tui" != xno; then if test -d $srcdir/tui; then if test "$curses_found" != no; then ... else if test x"$enable_tui" = xyes; then AC_MSG_ERROR([no enhanced curses library found; disable TUI]) else AC_MSG_WARN([no enhanced curses library found; disabling TUI]) fi fi fi fi So shouldn't the right check be this: if test x"$curses_found" != xyes; then ac_cv_search_tgetent="none required" CONFIG_OBS="$CONFIG_OBS windows-termcap.o" fi ;; ? Thanks, Pedro Alves