From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17595 invoked by alias); 20 Jan 2015 11:13:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17419 invoked by uid 89); 20 Jan 2015 11:13:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 20 Jan 2015 11:13:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0KBDHUv006606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 20 Jan 2015 06:13:18 -0500 Received: from localhost.localdomain (ovpn-112-57.ams2.redhat.com [10.36.112.57]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0KBDGGV023970; Tue, 20 Jan 2015 06:13:17 -0500 Message-ID: <54BE384C.6000605@redhat.com> Date: Tue, 20 Jan 2015 11:13:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: "Yichun Zhang (agentzh)" , gdb-patches Subject: Re: [PATCH] [python] Optimize python_string_to_host_string() for Python 2. References: <1421217481-18204-1-git-send-email-agentzh@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00536.txt.bz2 On 19/01/15 22:08, Yichun Zhang (agentzh) wrote: > Hello! > > On Tue, Jan 13, 2015 at 10:38 PM, Yichun Zhang (agentzh) wrote: >> With the following patch, my most complicated Python tools >> finally have comparable performance between Python 2 and >> Python 3. In the case of Python 2, some real-world Python scripts' >> overall speedup can be as big as 34% (for my "lgcpath" command [3]) >> or even 57% (for my "lgcstat" command [4]). And from the new Flame >> Graph [5], we can see that the corresponding function frames are >> indeed gone. >> >> Comments are welcome! >> > > Does the silence in the last 6 days mean that this patch is completely wrong? Not at all. I think the post Christmas catch-up has affected patch review and there is some lag. I am sure the maintainers will review your patch soon. > Actually I have a few more patches to submit to optimize this > gdb/python part even further. The silence here makes me hesitate ;) Please submit them. There is no hesitation on commenting on patches constructively. For my part, I find no issue with people indicating what might be wrong (or right) with my patches! > Please let me know if I'm doing something wrong here. Very much appreciated! You are doing nothing wrong. Keep pinging your patches. The usual wait time for pinging a patch is seven days. Cheers Phil