From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22339 invoked by alias); 9 Jan 2015 21:50:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22325 invoked by uid 89); 9 Jan 2015 21:50:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-209.mail.aliyun.com Received: from out1134-209.mail.aliyun.com (HELO out1134-209.mail.aliyun.com) (42.120.134.209) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Jan 2015 21:50:17 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.0742228|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r41f05020;MF=gang.chen@sunrus.com.cn;PH=DS;RN=5;RT=5;SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:223.72.65.45) by smtp.aliyun-inc.com(10.147.11.246); Sat, 10 Jan 2015 05:50:11 +0800 Message-ID: <54B04ED2.6010000@sunrus.com.cn> Date: Fri, 09 Jan 2015 21:50:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Iain Buclaw CC: gdb-patches@sourceware.org, Pedro Alves , Mark Kettenis , gcc-help@gcc.gnu.org Subject: Re: [PATCH v2] gdb/i387-tdep.c: Avoid warning for "-Werror=strict-overflow" References: <5r8dhveikyxjlpoi1mpvti2a.1413156892387@email.android.com> <546018BB.7090601@gmail.com> In-Reply-To: <546018BB.7090601@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00235.txt.bz2 At present, for gcc version 5.0.0 20150109 (experimental) (GCC), can not find this warning again. So this thread can be ended. If it will appear again in the future, I shall analyze it again only within gcc wide. And sorry for having delayed a long time for it. Thanks. On 11/10/14 09:45, Chen Gang wrote: > Hello Iain: > > Is this bug still alive (I joined in bug 63510)? If it is, I shall try > to fix it within this month (within 2014-11-30). > > At present, its status is: > > - gcc members think that what compiler has done is correct, but need > improve its report line number: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63510 > > - gdb members might think what compiler has done is incorrect (need not > report warning). > > - for me, I agree with gcc members' opinion, and shall try to improve > its report line number. > > > Welcome any ideas, suggestions and completions, in time. > > Thanks. > > On 10/13/14 7:45, Chen Gang wrote: >> Oh, really it is. Originally, I skipped it (do not know it should be as an issue, too). Also sorry for my poor English: misunderstand what you said (this patch can still continue, although gcc 5 has another issue). >> >> And next, I shall try to fix it, based on what bugzilla has done. But excuse me, I have no enough time resource on it, so maybe can not finish within this month (try to finish within next month) . >> >> Thanks >> >> Send from Lenovo A788t. >> >> >> Iain Buclaw wrote: >> >> On 12 October 2014 15:47, Chen Gang wrote: >>> On 10/12/14 22:13, Iain Buclaw wrote: >>>> On 12 October 2014 14:28, Chen Gang wrote: >>>>> gdb requires "-Werror", and I387_ST0_REGNUM (tdep) is 'variable', then >>>>> compiler can think that I387_ST0_REGNUM (tdep) may be a large number, >>>>> which may cause issue, so report warning. >>>>> >>>>> Need fix this warning, and still keep the code clear enough for readers. >>>>> The related warning under Darwin with gnu built gcc: >>>>> >>>> >>>> I had noted the same on GCC 5.0.0 development, found that the line >>>> number in the warning was wrong and raised a bug >>>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63510), just didn't get >>>> round to submitting a patch for gdb. >>>> >>> >>> But for me, what compiler has done is correct: "-Werror=strict-overflow" >>> need include "(X + c) >= X" for signed overflow. And our case matches >>> this case: >>> >> >> The compiler has done right, but that still doesn't stop the reported >> line number being wrong. >> >> -- Iain. >> > > Thanks. > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- Chen Gang Open, share, and attitude like air, water, and life which God blessed