From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17521 invoked by alias); 8 Jan 2015 11:03:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17505 invoked by uid 89); 8 Jan 2015 11:03:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 08 Jan 2015 11:03:50 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t08B3jSJ021310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Jan 2015 06:03:46 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t08B3fxO006978; Thu, 8 Jan 2015 06:03:45 -0500 Message-ID: <54AE640B.3000701@redhat.com> Date: Thu, 08 Jan 2015 11:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] TUI: rewrite tui_query_hook() References: <1420689048-23538-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1420689048-23538-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00168.txt.bz2 On 01/08/2015 03:50 AM, Patrick Palka wrote: > This patch rewrites tui_query_hook() to print things via tui_puts() and > to read in a line of input via wgetnstr(). The main motivation for this > rewrite is to get the backspace key to work correctly during a quit > prompt so that the user can revise their answer before pressing enter. > The backspace key now works correctly because we now use getstr() > instead of successive calls to getch(). Pagination, done in prompt_for_continue, gets away without this hook, as it's written in terms of readline. If we did the same to defaulted_query, I think the default code would just work for the TUI too. Did you consider that? Thanks, Pedro Alves