From: Pedro Alves <palves@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHSET] [2/4] Fix various issue in TUI
Date: Wed, 07 Jan 2015 13:48:00 -0000 [thread overview]
Message-ID: <54AD392C.1030209@redhat.com> (raw)
In-Reply-To: <834ms39a40.fsf@gnu.org>
On 01/06/2015 03:55 PM, Eli Zaretskii wrote:
> 2015-01-06 Eli Zaretskii <eliz@gnu.org>
>
> * tui/tui-win.c (tui_set_var_cmd): New function.
> (_initialize_tui_win) <border-kind, border-mode>:
> <active-border-mode>: Use tui_set_var_cmd as the "set" function.
>
> --- gdb/tui/tui-win.c~2 2015-01-04 08:07:30 +0200
> +++ gdb/tui/tui-win.c 2015-01-06 08:03:05 +0200
> @@ -346,6 +346,12 @@ tui_get_cmd_list (void)
> return &tuilist;
> }
>
> +void tui_set_var_cmd (char *null_args, int from_tty, struct cmd_list_element *c)
Line break after "void". Misses an intro comment, maybe something
like:
/* The set_func hook of "set tui ..." settings that affect
the TUI display. */
> +{
> + if (tui_update_variables ())
> + tui_rehighlight_all ();
The tui_rehighlight_all function is missing in this patch.
Did you indend for this to be tui_refresh_all_win?
Is this OK to call when the tui is not enabled?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-01-07 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 17:45 Eli Zaretskii
2015-01-05 19:11 ` Pedro Alves
2015-01-05 19:40 ` Eli Zaretskii
2015-01-06 16:03 ` Pedro Alves
2015-01-06 15:58 ` Eli Zaretskii
2015-01-07 13:48 ` Pedro Alves [this message]
2015-01-16 16:29 ` Eli Zaretskii
2015-01-16 16:59 ` Sergio Durigan Junior
2015-01-16 17:59 ` Eli Zaretskii
2015-01-16 16:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD392C.1030209@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox