From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32649 invoked by alias); 5 Jan 2015 19:55:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32635 invoked by uid 89); 5 Jan 2015 19:54:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 05 Jan 2015 19:54:56 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t05JssRH017419 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Jan 2015 14:54:54 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t05JshAM030905; Mon, 5 Jan 2015 14:54:48 -0500 Message-ID: <54AAEC02.7020500@redhat.com> Date: Mon, 05 Jan 2015 19:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCHSET] [4/4] Fix various issue in TUI References: <83vbkrbt4d.fsf@gnu.org> In-Reply-To: <83vbkrbt4d.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-01/txt/msg00057.txt.bz2 On 12/31/2014 05:56 PM, Eli Zaretskii wrote: > Well, one patch is Windows-specific after all. This patch makes sure > windows-termcap is not compiled when GDB is linked against ncurses, ... > and also makes the file a no-op should it compile in that > configuration. With the configure.ac change, how can that happen? > This is to avoid shadowing of ncurses functions by the > stubs in windows-termcap.c. > > OK to commit? > > 2014-12-31 Eli Zaretskii > > * gdb/configure.ac [mingw32]: Don't add windows-termcap.o to > CONFIG_OBJS if a curses library is going to be used. No "gdb/" prefix. > > * gdb/windows-termcap.c: Make the entire file a no-op if any > kind of curses library i being used. typo: "is". > > > --- gdb/configure.ac~0 2014-10-29 21:45:50 +0200 > +++ gdb/configure.ac 2014-12-30 07:42:27 +0200 > @@ -627,9 +627,10 @@ > ac_cv_search_tgetent="none required" > ;; > *mingw32*) > - ac_cv_search_tgetent="none required" > - CONFIG_OBS="$CONFIG_OBS windows-termcap.o" > - ;; > + if test x"$prefer_curses" = xyes; then > + ac_cv_search_tgetent="none required" > + CONFIG_OBS="$CONFIG_OBS windows-termcap.o" I'm confused on the predicate here. How can we tell from $prefer_curses that the curses library doesn't include termcap? AFAICS, if the TUI is enabled, it'll always be "yes". But isn't that the case where you _don't_ want windows-termcap.o? And shouldn't this be checking $curses_found? > + fi ;; > esac > > # These are the libraries checked by Readline. > > > --- gdb/windows-termcap.c~0 2014-06-11 18:34:41 +0300 > +++ gdb/windows-termcap.c 2014-12-29 15:42:44 +0200 > @@ -19,6 +19,11 @@ > You should have received a copy of the GNU General Public License > along with this program. If not, see . */ > > + > +#include "config.h" All files in gdb/ should start with "defs.h" instead. Thanks, Pedro Alves